Closed Bug 1041320 Opened 10 years ago Closed 10 years ago

Search tests require internet connection

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Search
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: daleharvey, Unassigned)

References

Details

(Whiteboard: [systemsfe][tako])

The various integrations tests that invoke the search application now require an internet connection since the firstrun notice is only displayed on search suggestion results. We should have the 'Search notification' test in search_test.js use a harness to test its behaviour, and we should replace |triggerFirstRun| with |disabledFirstRun| in the rest of the tests so they dont need to worry about a harness
Blocks: rocketbar-dogfood
Whiteboard: [systemsfe][tako]
Blocks: rocketbar-search-mvp
No longer blocks: rocketbar-dogfood
Nice to have, but I don't think this is release-blocking worthy. Let's get it done regardless, and if we do it in 2.1, we can uplift with a=test only.
Blocks: rocketbar-next
No longer blocks: rocketbar-search-mvp
They dont any more
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.