Closed Bug 1041339 Opened 10 years ago Closed 10 years ago

ServiceWorkers: Update implementation based on clarification of force-refresh.

Categories

(Core :: DOM: Workers, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: nsm, Assigned: nsm, Mentored)

References

Details

Attachments

(1 file)

Assignee: nobody → nicklebedev37
Assignee: nicklebedev37 → nsm.nikhil
As I see (if I'm not wrong) the implementation has not been updated yet. Nikhil, are you actively working on this bug? If not and you think this one would be another good-first-bug would you mind me to take it and work on it? Thanks!
Flags: needinfo?(nsm.nikhil)
(In reply to José Antonio Olivera Ortega [:jaoo] from comment #1) > As I see (if I'm not wrong) the implementation has not been updated yet. > Nikhil, are you actively working on this bug? If not and you think this one > would be another good-first-bug would you mind me to take it and work on it? > Thanks! If https://mxr.mozilla.org/mozilla-central/source/dom/base/nsDocument.cpp#4794 is the way to detect the navigation triggering request was initiated with a shift+reload I guess there is nothing to do here but remove the message you left. Please, let me know Nikhil.
(In reply to José Antonio Olivera Ortega [:jaoo] from comment #2) > (In reply to José Antonio Olivera Ortega [:jaoo] from comment #1) > > As I see (if I'm not wrong) the implementation has not been updated yet. > > Nikhil, are you actively working on this bug? If not and you think this one > > would be another good-first-bug would you mind me to take it and work on it? > > Thanks! > > If > https://mxr.mozilla.org/mozilla-central/source/dom/base/nsDocument.cpp#4794 > is the way to detect the navigation triggering request was initiated with a > shift+reload I guess there is nothing to do here but remove the message you > left. Please, let me know Nikhil. You are correct.
Flags: needinfo?(nsm.nikhil)
Attached patch v1 (deleted) — Splinter Review
Here is the patch in case you want to land it. Did a push to try, here is the link: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5faf70fee6e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: