Closed
Bug 1041339
Opened 10 years ago
Closed 10 years ago
ServiceWorkers: Update implementation based on clarification of force-refresh.
Categories
(Core :: DOM: Workers, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: nsm, Assigned: nsm, Mentored)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Updated•10 years ago
|
Assignee: nobody → nicklebedev37
Updated•10 years ago
|
Blocks: ServiceWorkers
Assignee | ||
Updated•10 years ago
|
Assignee: nicklebedev37 → nsm.nikhil
Assignee | ||
Updated•10 years ago
|
Comment 1•10 years ago
|
||
As I see (if I'm not wrong) the implementation has not been updated yet. Nikhil, are you actively working on this bug? If not and you think this one would be another good-first-bug would you mind me to take it and work on it? Thanks!
Flags: needinfo?(nsm.nikhil)
Comment 2•10 years ago
|
||
(In reply to José Antonio Olivera Ortega [:jaoo] from comment #1)
> As I see (if I'm not wrong) the implementation has not been updated yet.
> Nikhil, are you actively working on this bug? If not and you think this one
> would be another good-first-bug would you mind me to take it and work on it?
> Thanks!
If https://mxr.mozilla.org/mozilla-central/source/dom/base/nsDocument.cpp#4794 is the way to detect the navigation triggering request was initiated with a shift+reload I guess there is nothing to do here but remove the message you left. Please, let me know Nikhil.
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to José Antonio Olivera Ortega [:jaoo] from comment #2)
> (In reply to José Antonio Olivera Ortega [:jaoo] from comment #1)
> > As I see (if I'm not wrong) the implementation has not been updated yet.
> > Nikhil, are you actively working on this bug? If not and you think this one
> > would be another good-first-bug would you mind me to take it and work on it?
> > Thanks!
>
> If
> https://mxr.mozilla.org/mozilla-central/source/dom/base/nsDocument.cpp#4794
> is the way to detect the navigation triggering request was initiated with a
> shift+reload I guess there is nothing to do here but remove the message you
> left. Please, let me know Nikhil.
You are correct.
Flags: needinfo?(nsm.nikhil)
Comment 4•10 years ago
|
||
Here is the patch in case you want to land it. Did a push to try, here is the link:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5faf70fee6e
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 5•10 years ago
|
||
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•