Closed
Bug 1041403
Opened 10 years ago
Closed 10 years ago
Update mozL10n API use cases in shared
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zbraniecki, Assigned: zbraniecki)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Updated•10 years ago
|
|
|
Assignee | |
Comment 1•10 years ago
|
||
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•10 years ago
|
||
One big cluster of badly used mozL10n API are Dialogs. I filed a separate bug for that: bug 1041404.
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8459412 [details]
pull request
Tim, can you review this patch?
It does the following changes to ./shared/ code:
- moves from mozL10n.localize to mozL10n.setAttributes
- removes obsolete mozL10n.translate (MO should cover all the cases)
- moves from mozL10n.get to setAttribute('data-l10n-id');
Attachment #8459412 -
Flags: review?(timdream)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8459412 [details]
pull request
I assume you know what you are doing!
Attachment #8459412 -
Flags: review?(timdream) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Commit: https://github.com/mozilla-b2g/gaia/tree/c19c078bf2480d9eb5d43ff17bffc02460229d0e
Merge: https://github.com/mozilla-b2g/gaia/tree/9f6c4d671e83a40aee220b9c2ed8288a797df408
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•