Hi Marco, can you provide a point value.

Comment on attachment 8497135 [details] [diff] [review] patch v1 Review of attachment 8497135 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/places/UnifiedComplete.js @@ +1497,5 @@ > + })); > + } catch (ex) { > + // It's too late to block shutdown, just close the connection. > + yield conn.close(); > + throw ex; I'd not propagate the exception (btw, my caller in PlacesUtils doesn't do so either). @@ +1504,1 @@ > // Autocomplete often fallbacks to a table scan due to lack of text Fix the indention of the catch block (all 5 lines).

(In reply to Mano (::mano, needinfo? for any questions; not reading general bugmail) from comment #3) > ::: toolkit/components/places/UnifiedComplete.js > @@ +1497,5 @@ > > + })); > > + } catch (ex) { > > + // It's too late to block shutdown, just close the connection. > > + yield conn.close(); > > + throw ex; > > I'd not propagate the exception (btw, my caller in PlacesUtils doesn't do so > either). I think we should reject though, otherwise we would be hiding a mistake. And this does.