Closed
Bug 1041516
Opened 10 years ago
Closed 10 years ago
Don't allow Firefox to be the default browser but not check on startup to see if it's still the default browser
Categories
(Firefox :: Shell Integration, defect)
Firefox
Shell Integration
Tracking
()
Tracking | Status | |
---|---|---|
firefox36 | --- | verified |
People
(Reporter: verdi, Assigned: Gavin)
References
Details
(Whiteboard: [fxgrowth])
Attachments
(2 files, 2 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Currently the default browser and check on startup preferences are independent. This can lead to someone choosing Firefox as their default browser without Firefox checking if it's default on startup. This makes it easy for any other software installation to change this pref and Firefox will never prompt the user to change it back. We should protect the user's intent when they made Firefox their default browser and not allow this combination of settings.
Comment 1•10 years ago
|
||
(In reply to Verdi [:verdi] from comment #0)
> Currently the default browser and check on startup preferences are
> independent. This can lead to someone choosing Firefox as their default
> browser without Firefox checking if it's default on startup. This makes it
> easy for any other software installation to change this pref and Firefox
> will never prompt the user to change it back. We should protect the user's
> intent when they made Firefox their default browser and not allow this
> combination of settings.
I've read this paragraph multiple times and still don't understand what you mean. Can you try to clarify, perhaps with step by step instructions as to what you think is going wrong where?
Flags: needinfo?(mverdi)
Updated•10 years ago
|
Component: General → Shell Integration
Hardware: x86 → All
Version: 32 Branch → Trunk
Reporter | ||
Comment 2•10 years ago
|
||
Sorry - it's hard to describe. I made a video to help explain - http://people.mozilla.org/~mverdi/video/default-notchecking.webm
Flags: needinfo?(mverdi)
Reporter | ||
Updated•10 years ago
|
Whiteboard: [fxgrowth]
Assignee | ||
Comment 3•10 years ago
|
||
Essentially, we should force-on "check on every startup" (browser.shell.checkDefaultBrowser) when you click "make firefox my default".
Assignee | ||
Updated•10 years ago
|
Flags: qe-verify+
Flags: firefox-backlog+
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8504976 -
Flags: review?(gijskruitbosch+bugs)
Comment 6•10 years ago
|
||
Comment on attachment 8504976 [details] [diff] [review]
part 1: set the "Always ask" pref when setting ourselves as default
Review of attachment 8504976 [details] [diff] [review]:
-----------------------------------------------------------------
Mumble mumble code duplication.
Attachment #8504976 -
Flags: review?(gijskruitbosch+bugs) → review+
Updated•10 years ago
|
Attachment #8504973 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Assignee | ||
Comment 8•10 years ago
|
||
Fixed a dumb bug in part 0 and repushed for windows only:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=0d108509e2db
Assignee | ||
Comment 9•10 years ago
|
||
Needed to tweak a FUEL test that depended on browser.shell.checkDefaultBrowser being a user-set pref in the test environment (a previous test presumably calls setDefaultBrowser, which was setting the pref to true).
Attachment #8504976 -
Attachment is obsolete: true
Assignee | ||
Comment 10•10 years ago
|
||
forgot one s/prefBranch/prefs/
Attachment #8504973 -
Attachment is obsolete: true
Assignee | ||
Comment 11•10 years ago
|
||
Assignee | ||
Comment 12•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/cebde6059d78
https://hg.mozilla.org/integration/fx-team/rev/8222e6881da4
Flags: in-testsuite-
Target Milestone: --- → Firefox 36
Comment 13•10 years ago
|
||
Presumably I can override this is user.js? Otherwise this breaks things for me.
Comment 14•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cebde6059d78
https://hg.mozilla.org/mozilla-central/rev/8222e6881da4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Iteration: --- → 36.1
Comment 15•10 years ago
|
||
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Nightly 36.0a1 (buildID: 20141022030202).
Status: RESOLVED → VERIFIED
status-firefox36:
--- → verified
You need to log in
before you can comment on or make changes to this bug.
Description
•