Open
Bug 104170
Opened 23 years ago
Updated 2 years ago
FastLoad file contains many redundant (sub)strings
Categories
(Core :: XPCOM, defect, P3)
Core
XPCOM
Tracking
()
NEW
Future
People
(Reporter: brendan, Unassigned)
References
Details
(Keywords: perf)
JS atoms are flattened (this is really a JS XDR bug/misfeature) into strings as
they are serialized. URI specs and file pathnames are not compressed if
relative to an earlier base. Etc.
/be
Reporter | ||
Updated•23 years ago
|
Reporter | ||
Comment 1•23 years ago
|
||
Following bug 107907 to 0.9.7.
/be
Keywords: mozilla0.9.6 → mozilla0.9.7
Target Milestone: mozilla0.9.6 → mozilla0.9.7
Reporter | ||
Comment 2•23 years ago
|
||
Design note to self: JS XDR is a lower below the object/binary stream
implemented by nsFastLoadFile{Reader,Writer}. Both layers want a dictionary of
shared strings (for strings long enough to be worth sharing). A new interface,
nsIFastLoadStringTable (or perhaps a more generic name), should be implemented
and used by nsFastLoadFileWriter::WriteString, etc.
/be
Reporter | ||
Comment 3•23 years ago
|
||
This one is following bug 107907 to 0.9.8.
/be
Keywords: mozilla0.9.7 → mozilla0.9.8
Target Milestone: mozilla0.9.7 → mozilla0.9.8
Reporter | ||
Comment 4•23 years ago
|
||
Still want this for 1.0, which means 0.9.9 or bust.
/be
Keywords: mozilla0.9.8 → mozilla1.0
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Reporter | ||
Comment 5•23 years ago
|
||
Bust. This is not vital for 1.0 unless someone can show a big startup perf gain
over what FastLoad currently gives. The file (not RAM, except for the extra
i/o) footprint doesn't matter enough to rush this in.
/be
Reporter | ||
Updated•23 years ago
|
Keywords: mozilla1.0 → mozilla1.1
Target Milestone: mozilla0.9.9 → mozilla1.1
Reporter | ||
Comment 6•22 years ago
|
||
I'm an optimist.
/be
Target Milestone: mozilla1.1alpha → mozilla1.1beta
Reporter | ||
Comment 7•22 years ago
|
||
This is 1.2alpha material, not 1.1beta.
/be
Keywords: mozilla1.1 → mozilla1.2
Target Milestone: mozilla1.1beta → mozilla1.2alpha
Reporter | ||
Comment 8•22 years ago
|
||
Moving out, some of these may move to 1.3alpha shortly.
/be
Target Milestone: mozilla1.2alpha → mozilla1.2beta
Reporter | ||
Updated•22 years ago
|
Target Milestone: mozilla1.3beta → mozilla1.5alpha
Reporter | ||
Updated•21 years ago
|
Target Milestone: mozilla1.5alpha → mozilla1.6alpha
Reporter | ||
Updated•21 years ago
|
Target Milestone: mozilla1.6alpha → Future
Updated•18 years ago
|
QA Contact: scc → xpcom
Reporter | ||
Comment 11•15 years ago
|
||
Comment 10 and the dependency on bug 520309 say that this bug must wait, but see bug 517956 comment 2 for reference to bz's specific script->filename issue, which could be fixed ad-hoc.
/be
Reporter | ||
Comment 12•15 years ago
|
||
Ben, feel free to steal or dup.
/be
Assignee: brendan → nobody
Status: ASSIGNED → NEW
Comment 13•14 years ago
|
||
I guess this is a sort of metabug now?
I have patches in bug 518230 and bug 632253 which reduce the size of serialized scripts a bunch. XPIProvider.jsm is 40% smaller with those patches. However, the serialized js is still bigger than the original js when compressed.
Comment 14•12 years ago
|
||
Is this a problem specific to XDR? Does this even still exist with s/fastload/startupcache/?
Priority: P2 → P3
Comment 15•12 years ago
|
||
(In reply to Benjamin Smedberg [:bsmedberg] from comment #14)
> Is this a problem specific to XDR? Does this even still exist with
> s/fastload/startupcache/?
yes see comment 13
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•