Closed Bug 1041743 Opened 10 years ago Closed 9 years ago

Add ability to turn on/off Search Suggestions in preferences

Categories

(Firefox :: Address Bar, defect)

x86
All
defect
Not set
normal
Points:
3

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: sevaan, Unassigned)

References

Details

Attachments

(3 files)

A checkbox needs to be added to the "Content" section of Firefox preferences which allows users to turn on/off Search Suggestions in the Awesome Bar. String: ☑ Show search suggestions in Awesome Bar.
Depends on: 1041747
Blocks: 1041736
Flags: firefox-backlog+
Flags: qe-verify?
Shouldn't this appear under Privacy (or, dare I say it - General)? Content is about what gets displayed inside the tab / "viewport", and this is about a browser feature.
Flags: needinfo?(sfranks)
(In reply to :Gijs Kruitbosch from comment #1) > Shouldn't this appear under Privacy (or, dare I say it - General)? Content > is about what gets displayed inside the tab / "viewport", and this is about > a browser feature. Yes, I suppose you are right. I didn't consider the Privacy tab, but now I see that other Location Bar preferences are under it. Let's move it to the Privacy tab as per your suggestion. Thanks!
Flags: needinfo?(sfranks)
Points: --- → 3
Assignee: nobody → abardas
Status: NEW → ASSIGNED
Iteration: --- → 35.2
There's already a dropdown labeled "When using the location bar, suggest:". That should include search suggestions, no? It doesn't really make sense to have both that dropdown and then a separate checkbox for search suggestions. The two should be consolidated somehow. Now that we have three choices -- history, bookmarks, and search suggestions -- would three checkboxes be appropriate?
Flags: needinfo?(sfranks)
Flags: qe-verify? → qe-verify+
bug 530209 :) The problem is that autocomplete prefs suck. you can workaround something here sure, but the problem is larger.
I already have some work in progress here that would hopefully also solve bug 530209. I can easily provide patches for each bug (the one from this should be rebased on top of the one from bug 530209). I'd like to have an updated mockup to adjust my WIP.
Depends on: 530209
(In reply to Drew Willcoxon :adw from comment #3) > Now that we have three choices -- history, bookmarks, and search suggestions > -- would three checkboxes be appropriate? Yes, this is an elegant solution, rather than adding an extra option into the dropdown. Good thinking!
Flags: needinfo?(sfranks)
Blocks: 1071461
QA Contact: alexandra.lucinet
Assigning this to myself since I'm already working on several other related bugs.
QA Contact: alexandra.lucinet → andrei.vaida
Iteration: 35.2 → 35.3
Assignee: abardas → nobody
Status: ASSIGNED → NEW
Iteration: 35.3 → ---
WFM in 38
we implemented the option in privacy / Location Bar, further work will happen elsewhere once designed (shorlander on that).
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: