Closed Bug 1041917 Opened 10 years ago Closed 10 years ago

[e10s] Bugzilla doesn't load when I file a bug from "mozilla crash reports"

Categories

(Firefox :: Tabbed Browser, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1047603
Tracking Status
e10s m2+ ---

People

(Reporter: alice0775, Assigned: mossop)

References

Details

Attachments

(1 obsolete file)

Steps To Reproduce: 1. Make sure e10s, set browser.tabs.remote.autostart = true and restart 2. Tab Crashed 3. Open about:crashes and Click a crash ID to open "mozilla crash reports" 4. Click one of link "Bugzilla - Report this bug in". Actual Results: New tab opened, but nothing load in the tab Expected Results: Bugzilla should be loaded
When I click one of link "Bugzilla - Report this bug in". An error shown in Error Console: Error: NS_ERROR_ABORT: User canceled master password entry Source File: resource://gre/components/crypto-SDR.js Line: 163
Component: General → Password Manager
Product: Firefox → Toolkit
Assignee: nobody → mrbkap
Blocks: old-e10s-m2
tracking-e10s: --- → +
The fact that the link clicks don't work is bug 1047603. That being said, we should also probably move about:crashes to the content process.
Depends on: 1047603
about:crashes does require chrome privs, FWIW.
Comment on attachment 8472499 [details] [diff] [review] Make it possible to transition from non-remote to remote browsers while browsing away from about: pages. r=? Hey Blake, How do you feel about this solution? This makes it possible to transition from non-remote browsers on about: pages to remote browsers when the location changes to a remote-able URI. This will fix the reporters bug, though doesn't fix the underlying issue of being able to open non-remote tabs from non-remote tabs in an e10s window.
Attachment #8472499 - Flags: feedback?(mrbkap)
Attachment #8472499 - Flags: feedback?(mrbkap) → feedback+
Comment on attachment 8472499 [details] [diff] [review] Make it possible to transition from non-remote to remote browsers while browsing away from about: pages. r=? Are you comfortable reviewing this, billm?
Attachment #8472499 - Flags: review?(wmccloskey)
Attachment #8472499 - Flags: review?(wmccloskey) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla34
Depends on: 1056438
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
So this seemed to cause a few problems: 1) Bug 1056438 - if about:addons, or any non-remote tab was in a session that is restored, session restore would break. 2) bjacob, ehsan and I noticed that in debug builds, if we killed and restored a session, we'd fail this assertion: MOZ_ASSERT(mBlockDOMContentLoaded); from: http://hg.mozilla.org/mozilla-central/file/dac8b4a0bd7c/content/base/src/nsDocument.cpp#l4928 which, according to ehsan, is highly undesirable.
Depends on: 999239
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
(In reply to Wes Kocher (:KWierso) from comment #12) > https://hg.mozilla.org/mozilla-central/rev/e5a507b9a576 This bug should stay in "REOPENED".
Flags: needinfo?(kwierso)
(In reply to Alice0775 White from comment #13) > (In reply to Wes Kocher (:KWierso) from comment #12) > > https://hg.mozilla.org/mozilla-central/rev/e5a507b9a576 > > This bug should stay in "REOPENED". Yeah, messed up the mc-merge script for some stuff.
Status: RESOLVED → REOPENED
Flags: needinfo?(kwierso)
Resolution: FIXED → ---
(In reply to Mike Conley (:mconley) from comment #11) > So this seemed to cause a few problems: > > 1) Bug 1056438 - if about:addons, or any non-remote tab was in a session > that is restored, session restore would break. > 2) bjacob, ehsan and I noticed that in debug builds, if we killed and > restored a session, we'd fail this assertion: 3) It broke mochitest-e10s-2 on gtk3 builds on elm: - turned red when landing the merge containing this patch https://tbpl.mozilla.org/?tree=Elm&rev=27440eb3e1c3 - turned back orange (yeah, orange is the "normal" color on those builds) when landing the merge of the backout https://tbpl.mozilla.org/?tree=Elm&rev=6ca50c5d0437 - bisected on try: https://tbpl.mozilla.org/?tree=Try&rev=42e4162ca647 last good https://tbpl.mozilla.org/?tree=Try&rev=42e8bb33926f first bad (disregard the first debug mochitest-e10s-2 red, it was triggered manually and didn't actually use the debug build) It would be interesting to know why those turned red when they didn't on other platforms.
I guess I should paste the failures: 3165 INFO TEST-UNEXPECTED-ERROR | /tests/dom/base/test/test_Image_constructor.html | Assertion count 2 is greater than expected range 0-0 assertions. 3251 INFO TEST-UNEXPECTED-FAIL | /tests/dom/base/test/test_bug1043106.html | Test timed out.
I have a patch that cleans up transitions between non-remote and remote browsers that fixes this.
Assignee: mrbkap → dtownsend+bugmail
Component: Password Manager → Tabbed Browser
Product: Toolkit → Firefox
Target Milestone: mozilla34 → ---
Summary: [e10s] Bugzilla is not load when I file a bug from "mozilla crash reports" → [e10s] Bugzilla doesn't load when I file a bug from "mozilla crash reports"
Flags: firefox-backlog+
Status: REOPENED → ASSIGNED
Flags: qe-verify?
Iteration: --- → 35.1
Points: --- → 1
Flags: qe-verify? → qe-verify+
This bug should be fixed for the e10s M2 milestone.
Attachment #8472499 - Attachment is obsolete: true
This is going to be fixed by bug 1047603.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → DUPLICATE
Iteration: 35.1 → ---
Points: 1 → ---
Flags: firefox-backlog+ → firefox-backlog-
That solves the user impact of the issue, I filed bug 1066694 to track the remaining problem.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: