Closed
Bug 1041942
Opened 10 years ago
Closed 10 years ago
[System] Move Clock from statusbar.js to clock.js
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gweng, Assigned: gweng)
References
Details
(Whiteboard: [p=1])
Attachments
(1 file)
Now there is a 'Clock' function in the 'statusbar.js'. However, it is not only for statusbar, that LockScreen also needs it (Bug 864516), and it's unreasonable to put two components in the same file. So I would move it out.
|
Assignee | |
Comment 1•10 years ago
|
||
I also fix the 'statusbar.js' to make it passes JSHint check.
|
|
Assignee | |
Updated•10 years ago
|
Whiteboard: [p=1]
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8460066 [details]
Patch
The patch passed all tests except one timeout, so I set the review.
Attachment #8460066 -
Flags: review?(alive)
|
||
Updated•10 years ago
|
Attachment #8460066 -
Flags: review?(alive) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/1ed6e2fd4efc0b1c6a664898c1b9ff7c8c2dac3a
To make Clock as instantiable with no or fewest risk, I would like to solve it in another bug.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•