vasanth Assignee
	Description • 10 years ago

[Blocking Requested - why for this release]:

Steps to Reproduce:
   1. Open music app and start playing an offload capable music clip (mp3)
   2. Go to Settings and Turnon Bluetooth.
   3. Pair and connect to a BT headset.
   4. Once BT headset is connected playback resumes from the beginning of the clip.

Root cause:
   SeekTarget takes time in int64_t usecs whereas we pass double seconds in 2 places. Attached patch fixes this issue.

	vasanth Assignee
	Comment 1 • 10 years ago

Thanks Robert!
Submitted my first Try run https://tbpl.mozilla.org/?tree=Try&rev=3765c7f8fd08

	vasanth Assignee
	Comment 2 • 10 years ago

Try run looks successful. Starred the only error.
Adding checkin-needed

	Carsten Book [:Tomcat]
	Comment 3 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/9caeb48e2eb8

	Ryan VanderMeulen [:RyanVM]
	Comment 4 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/9caeb48e2eb8

	Ryan VanderMeulen [:RyanVM]
	Comment 5 • 10 years ago

https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/3100edc0df15

	Ada [:adalucinet]
	Comment 6 • 10 years ago

I see that the affected platform here is Firefox OS. Is there something to be done on Firefox Desktop as well? Thanks in advance!

	vasanth Assignee
	Comment 7 • 10 years ago

(In reply to Alexandra Lucinet, QA Mentor [:adalucinet] from comment #6)
> Is there something to be done on Firefox Desktop as well? Thanks in advance!

I guess part of this change in MediaDecoder.cpp [1] should fix if this issue comes up in Firefox desktop.

May be we can check MediaDecoder::SeekTarget is initialized with int64_t micro seconds instead of double seconds everywhere, just to make sure same issue doesn't exist in desktop specific code.

Forwarding ni to author of SeekTarget as he might know better than me.

[1] https://bugzilla.mozilla.org/attachment.cgi?id=8460143&action=diff#a/content/media/MediaDecoder.cpp_sec2

	Chris Pearce [:cpearce (Not reading bugmail)]
	Comment 8 • 10 years ago

Desktop Firefox doesn't (yet) make decoders dormant, so Desktop Firefox should not be affected this issue.

	[:RJ]
	Comment 9 • 10 years ago

This will need to be covered by a new test case.

	KTucker [:KTucker][Inactive 3/4/2016]
	Comment 10 • 10 years ago

Test case added to moztrap:

https://moztrap.mozilla.org/manage/case/14378/

	Paladin
	Comment 11 • 10 years ago

(In reply to vasanth from comment #0)
> Steps to Reproduce:
>    1. Open music app and start playing an offload capable music clip (mp3)
Hi Vasanth,
Could you please tell me what audio format the offload capable music clip (mp3) is？