While the application attempts to disable flash when focusing, it does not consistently work on Flame. If the flash is on while focusing, and that focus is interrupted, the flash remains on after the focus is complete. It may be turned off only by exiting the camera app or by cycling flash modes. STR: 1) Enter camera app and put flash mode into either auto or on. 2) Tap to focus on an area that would trigger the flash. 3) Quickly tap to focus again before the focus completes / the flash is turned off. 4) Focus completes but flash remains on.

Comment on attachment 8460258 [details] [diff] [review] Queue instead of interrupt, v1 The patch looks fine to me, but I'd like to hold off on the r+ until justin or someone else from the app side can confirm that this doesn't adversely affect touch-to-focus (and the patch in bug 1022766).

(In reply to Mike Habicher [:mikeh] from comment #2) > Comment on attachment 8460258 [details] [diff] [review] > Queue instead of interrupt, v1 > > The patch looks fine to me, but I'd like to hold off on the r+ until justin > or someone else from the app side can confirm that this doesn't adversely > affect touch-to-focus (and the patch in bug 1022766). That is the same scenario as I think I have been testing. But I think they need another change in apps related to this; when the flash mode is preserved before disabling, they need to remember/restore the *original* setting in the event more focus requests come in, instead of restoring the last one. That ignores the fact that this doesn't seem to be actually disabling flash most of the time on flame, since the service doesn't handle the change until too late; the second focus will usually lack the flash. It is also inconsistent with when the camera service decides to focus automatically, as it would turn on the flash then.

Comment on attachment 8460258 [details] [diff] [review] Queue instead of interrupt, v1 Haven't looked over this yet, but since it involves tap-to-focus, flagging Diego for feedback since that's kinda his territory :-)

Can you trigger a gaia-try build for flame?

try: https://tbpl.mozilla.org/?tree=Try&rev=9537c2f3dd48

flame b2g binaries: https://dl.dropboxusercontent.com/u/85398890/bug1042072.b2g.jul28.tar.gz

Comment on attachment 8460258 [details] [diff] [review] Queue instead of interrupt, v1 Review of attachment 8460258 [details] [diff] [review]: ----------------------------------------------------------------- Looks fine to me--still waiting on feedback from the apps guys.

Comment on attachment 8460258 [details] [diff] [review] Queue instead of interrupt, v1 Review of attachment 8460258 [details] [diff] [review]: ----------------------------------------------------------------- Tested and it works great!

Testing reveals that the changes in bug 1056173 are sufficient to resolve the flash mode related issues. This is not reproducible on kk so it looks like they resolved the issue in the driver, nor is it reproducible on jb with the changes from bug 1056173. Additionally, with the changes in *this* bug, it has some weird interactions when interrupting touch to focus before switching between picture/video record mode (i.e. focus rings get stuck due to no callback from the driver). We'll need to keep an eye out for not receiving callbacks from auto focus but track that separately.