Closed Bug 1042489 Opened 10 years ago Closed 10 years ago

Crash [@ nsBlockReflowContext::ComputeCollapsedBStartMargin] with -moz-column, box-decoration-break: clone

Categories

(Core :: Layout, defect)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: jruderman, Assigned: MatsPalmgren_bugz)

References

Details

(Keywords: assertion, crash, testcase)

Attachments

(4 files)

Attached file testcase (deleted) —
No description provided.
Attached file stack (deleted) —
Attached file frame tree dump (deleted) —
We expect that a nsColumnSetFrame always has an inner frame to hold the frames of the content children; and we do, it's just that it still sits on the overflow list of the prev-in-flow from the time the continuation is created until it's reflowed.
Assignee: nobody → mats
Attached patch fix+crashtest (deleted) — Splinter Review
Call DrainOverflowColumns() to pick up any overflow frames from our prev-in-flow. And do a null-check even after that b/c I suspect that in rare cases involving overflow containers a ColumnSetFrame might not have a child frame. https://tbpl.mozilla.org/?tree=Try&rev=4e79913be6d4
Attachment #8478199 - Flags: review?(roc)
Keywords: crash
OS: Mac OS X → All
Hardware: x86_64 → All
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Setting as qe-verify- since this has a test (layout/generic/crashtests/1042489.html).
Flags: qe-verify-
Flags: qe-verify+
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: