Closed Bug 104258 Opened 23 years ago Closed 23 years ago

Dlg for setting to default mail should not appear when I'm composing a msg

Categories

(MailNews Core :: Simple MAPI, defect, P3)

x86
Windows NT
defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.8

People

(Reporter: lchiang, Assigned: srilatha)

References

Details

Attachments

(1 file, 2 obsolete files)

Dlg for setting to default mail should not appear when I'm composing a msg Win32 2001-10-11-10-094 branch build One profile only Preference set to launch both browser and mail at startup of program 1. Make sure you have the preference set to use MAPI Send in Netscape 6. Exit Netscape 6. 2. Start Netscape 6 3. Browser window appears. Mail window appears. Login to mail (IMAP) 4. Edit | Preferences 5. Disable the preference to use MAPI Send 6. Click OK 7. Back at the 3pane mail window, select a message and reply to it 8. Compose window appears, but you get a dialog: "Do you want to use Netscape 6 as the default mail application." This is a strange time to put up this dialog. I don't believe this is related to 103908 since I've never checked the box to not show me this dialog again.
that's strange lisa. You should have seen the mapi dialog when the mail window appears. But you didn't see it until you brought up a compose window?
you'll get the dialog when launching the 3 pane, compose or address book, because we piggy back off of verifyAccounts(). is this check only supposed to happen when using the 3 pane?
Srilatha will work on this.
Assignee: tiantian → srilatha
Priority: -- → P3
using verifyAccounts() makes it so if we are going to put up the mapi dialog, we do so on the first "mailnews" window, which includes the 3 pane, compose and addressbook. but reading lisa's original comment, this sounds like a problem with how we figure out if we want to show the dialog or not.
Seth is right. This is the problem with how how we figure out if we want to show the dialog or not. I have a fix for this. I will have to test it little bit and then I'll post a patch.
Attached patch patch v1 (obsolete) (deleted) — Splinter Review
ccing ssu for r= mscott can you do the sr=
We might want to take this one, if this happens more than once in a session.
Keywords: nsbranch
Whiteboard: [PDT]
Comment on attachment 53313 [details] [diff] [review] patch v1 r=ssu
Attachment #53313 - Flags: review+
This happens only once per session. The next time, I'll see this dlg at the "normal time" which is when I start mail (3pane) comes up.
Comment on attachment 53313 [details] [diff] [review] patch v1 sr=mscott
Attachment #53313 - Flags: superreview+
lisa once per session means every time you start the app right? And not once per profile? If the former, then it sounds severe due to the frequent visibility.
The resulting behavior is not severe. When this "ask me" dialog comes up in the Compose window (following my original steps), I choose NO, but I leave the "don't ask me again" checkbox unchecked. I see this dialog again each subsequent time I start Netscape 6. That is acceptable since I never checked the "don't ask me again" checkbox. This bug report should be for the logic that within the same session, if I've just disabled MAPI, the application should not turn around and ask me again to make us the default application.
What Lisa did was launch Mail, turn the MAPI pref Off, launch a compose window, and then was prompted (default mail client). If mail is already running, and the user turns the pref off, we shouldn't prompt them when they launch a new mail window (during the same session). When they quit Mail and then relaunch Mail, then bug them. :-)
If this is accpetable, then let's go ahead and PDT- for 094, right?
With the patch, in the test case mentioned by Lisa, we bring up the dialog When the user quits The whole application and then relaunch Mail. Jennifer is that ok.
If Lisa is fine with that, fine with me. :-)
PDT-, its too late to be making dialogue changes at this time.
Keywords: relnote
Whiteboard: [PDT] → [PDT-]
We are not added new dialog. We are just changing the time when the dialog will be displayed.
Still PDT-.
Blocks: 107065
Keywords: nsbranch
Blocks: 103807
Target Milestone: --- → mozilla0.9.7
Target Milestone: mozilla0.9.7 → mozilla0.9.8
Attached patch updated patch (obsolete) (deleted) — Splinter Review
updated the patch against the head
Attached patch updated patch (deleted) — Splinter Review
updated the patch against the head
Attachment #53313 - Attachment is obsolete: true
Attachment #64344 - Attachment is obsolete: true
Comment on attachment 64345 [details] [diff] [review] updated patch sr=mscott
Attachment #64345 - Flags: superreview+
Comment on attachment 64345 [details] [diff] [review] updated patch r=ssu
Attachment #64345 - Flags: review+
Fix checked in.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Removign PDT grafitti.
Whiteboard: [PDT-]
verified on trunk 2002042512
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
Keywords: relnote
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: