Web page not drawn as high contrast themes Steps To reproduce: 1. Make sure Windows visual style set to High contrast #1 2. Start Firefox 3. Open web page Actual Results: See Screenshot, Web page not drawn as high contrast themes Regression window(m-c) Good: https://hg.mozilla.org/mozilla-central/rev/88ae1bfaaf3d Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140328161633 Broken contents and subview: https://hg.mozilla.org/mozilla-central/rev/4f3443da36a1 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140328164933 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=88ae1bfaaf3d&tochange=4f3443da36a1 #2 Regression window(fx) Good: https://hg.mozilla.org/integration/fx-team/rev/38c8dbb6ad87 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140328024048 Bad: https://hg.mozilla.org/integration/fx-team/rev/d8a36b893b2b Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140328031646 Pushlog: http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=38c8dbb6ad87&tochange=d8a36b893b2b Regressed by:: d8a36b893b2b Gijs Kruitbosch ? Bug 946595 - High contrast themes on Windows 8 shouldn't be considered the default theme in CSS, r=jimm

*sound of head banging against desk* I can't believe I missed this.

Jenn, can you add this for this iteration? Anthony, can you add this to the QA test protocol/suite? We can't automated-test switching the OS theme, but we should never ever ship this state again.

Florin, please get a Moztrap test added to our regression testrun.

Added to Iteration 34.1

New test case: https://moztrap.mozilla.org/manage/caseversion/136170/?from=/manage/cases/. Test was added to the Firefox 32 Regression Test Run. Anthony feel free to review it and contact me if you think anything else is needed.

Greetings and salutations from the Scottish Highlands, where this comment will probably take more time to make it to bugzilla than writing it took me... :-) https://hg.mozilla.org/integration/fx-team/rev/bf57c733f1fe

Reproduced the issue on Win 7 x64 with Firefox 34 Nightly from July 30th. The issue no longer reproduced on Win 7 x64 with the latest Firefox 34 Nightly: - BuildID: 20140731030206 - User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:34.0) Gecko/20100101 Firefox/34.0 I've tried all 4 High Contrast Themes (#1, #2, Black, White) and web pages are displayed accordingly, same as on Firefox 28.

Gijs - This is tracked for Beta and Aurora. Can you submit an uplift request?

Comment on attachment 8461927 [details] [diff] [review] Patch (In reply to Lawrence Mandel [:lmandel] from comment #9) > Gijs - This is tracked for Beta and Aurora. Can you submit an uplift request? Yes - apologies for the delay, I was on PTO (was noted in my nickname - it would be nice if bugzilla warned/noted this when requesting needinfo, so you could have picked someone else). Requesting approval for beta, aurora and 31 esr: [Approval Request Comment] If this is not a sec:{high,crit} bug, please state case for ESR consideration: major regression due to bug 946595 completely broke high contrast themes. User impact if declined: high contrast themes don't work. Fix Landed on Version: 34 Risk to taking this patch (and alternatives if risky): very very low - just moving the detection block for high contrast themes before an early return which high contrast themes always hit on Windows versions before Windows 8. String or UUID changes made by this patch: none See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Comment on attachment 8461927 [details] [diff] [review] Patch Approving for Aurora, Beta and ESR31. Note on ESR31: approving as this is a regression to an a11y feature.

https://hg.mozilla.org/releases/mozilla-aurora/rev/f1c049a566e2 https://hg.mozilla.org/releases/mozilla-beta/rev/19d074395f1a https://hg.mozilla.org/releases/mozilla-esr31/rev/0aebd77952a7

The issue no longer reproduces on Win 7 x64 with: - latest Firefox 33 Aurora - BuildID: 20140805004001 - User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 - Firefox 32 Beta 4 - BuildID: 20140804164216 - User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 I've verified all 4 High Contrast Themes (#1, #2, Black, White) and web pages are displayed accordingly.