Closed
Bug 1042685
Opened 10 years ago
Closed 10 years ago
Correct LIBS definition for Qt Widget
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla34
People
(Reporter: evilpie, Assigned: evilpie)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8460889 -
Flags: review?(mh+mozilla)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8460889 [details] [diff] [review]
v1
Review of attachment 8460889 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/library/libxul.mk
@@ +208,5 @@
> endif
>
> ifeq (cocoa,$(MOZ_WIDGET_TOOLKIT))
> ifdef MOZ_GSTREAMER
> LIBS += $(GSTREAMER_LIBS)
Please change this one too.
Attachment #8460889 -
Flags: review?(mh+mozilla) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
Sure. I hope OS_LIBS is right for that as well! Thanks.
https://hg.mozilla.org/integration/mozilla-inbound/rev/810551a5ee64
|
||
Updated•10 years ago
|
Assignee: nobody → evilpies
|
||
Comment 3•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
QA Whiteboard: [qa-]
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•