Closed
Bug 1042825
Opened 10 years ago
Closed 10 years ago
Pressing undo twice after loading a file clears out the content
Categories
(DevTools Graveyard :: WebIDE, defect)
DevTools Graveyard
WebIDE
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 34
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
STR:
1) Open a file in the project editor (say, styles.css here: chrome://browser/content/devtools/projecteditor-loader.xul)
2) Undo twice
Expected
Nothing happens when undoing (the file just loaded and you haven't made any changes)
Actual
The contents of the editor is cleared out
There is a clearHistory provided by the Editor object, so it may just be as simple as calling that after calling setText in editor.load
|
Assignee | |
Comment 1•10 years ago
|
||
This fixes the issue
Comment on attachment 8469254 [details] [diff] [review]
undo-clear.patch
Review of attachment 8469254 [details] [diff] [review]:
-----------------------------------------------------------------
Seems to work well! Thanks!
Attachment #8469254 -
Flags: review?(jryans) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Keywords: checkin-needed
|
||
Comment 4•10 years ago
|
||
|
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
QA Whiteboard: [qa+]
|
||
Comment 6•10 years ago
|
||
Verified as fixed using latest Aurora 34.0a2 build (20141008004004) under Win 7 64-bit, Ubuntu 13.04 64-bit and Mac OSX 10.9.5. Undo is active only after modifying file's content.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•