Closed
Bug 1042857
Opened 10 years ago
Closed 10 years ago
Unify WebIDE's deck style.
Categories
(DevTools Graveyard :: WebIDE, defect)
DevTools Graveyard
WebIDE
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 34
People
(Reporter: janx, Assigned: janx)
References
Details
Attachments
(2 files, 1 obsolete file)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
janx
:
review+
|
Details | Diff | Splinter Review |
before-after.png
Several CSS rules were copy-pasted across the WebIDE decks.
|
Assignee | |
Comment 1•10 years ago
|
||
Runtime Info and Permissions can also benefit from the common style.
Summary: CSS code duplication in the WebIDE decks → Unify WebIDE's deck style.
|
|
Assignee | |
Comment 2•10 years ago
|
||
|
|
Assignee | |
Comment 3•10 years ago
|
||
No visual changes to Addons and Preferences, but Permissions Table and Runtime Info were updated to the new style.
|
|
Assignee | |
Comment 4•10 years ago
|
||
Comment on attachment 8461040 [details] [diff] [review]
Unify WebIDE's deck style.
Paul, please have a look.
I'm going to use deck.css in the Monitor.
Attachment #8461040 -
Flags: review?(paul)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Comment on attachment 8461040 [details] [diff] [review]
Unify WebIDE's deck style.
Review of attachment 8461040 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/devtools/webide/themes/tabledoc.css
@@ +6,1 @@
> background: white;
Maybe we even want to use deck.css' linear-gradient instead of white?
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8461040 [details] [diff] [review]
Unify WebIDE's deck style.
> Maybe we even want to use deck.css' linear-gradient instead of white?
(you mean addons.css?) Up to you.
Also - maybe you want to merge tabledoc.css inside this file too (not necessary - up to you).
Attachment #8461040 -
Flags: review?(paul) → review+
|
|
Assignee | |
Comment 7•10 years ago
|
||
Kept white for `Runtime Info` and `Permissions`, merged `tabledoc.css` into `deck.css`.
Attachment #8461040 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 8•10 years ago
|
||
Comment on attachment 8461481 [details] [diff] [review]
Unify WebIDE's deck style.
Carry over Paul's r+.
Attachment #8461481 -
Flags: review+
|
|
Assignee | |
Comment 9•10 years ago
|
||
(No functional change so no need for a try run.)
Keywords: checkin-needed
|
||
Comment 10•10 years ago
|
||
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
QA Whiteboard: [qa-]
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•