Closed Bug 1043045 Opened 10 years ago Closed 10 years ago

Port |Bug 1036894 - Move in-tree library linkage information to moz.build| to im

Categories

(Instantbird Graveyard :: Other, defect)

Product:
Instantbird Graveyard
Component:
Other
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: clokep, Assigned: florian)

References

Details

Attachments

(3 files, 5 obsolete files)

im/ changes v3
(deleted), patch
clokep
: review+
Details | Diff | Splinter Review
purple/ changes v4
(deleted), patch
clokep
: review+
Details | Diff | Splinter Review
purple/ Linux follow-up
(deleted), patch
clokep
: review+
Details | Diff | Splinter Review
Attached patch im changes WIP v1 (obsolete) (deleted) — — Splinter Review
There's a few build bustages, let's handle them here.
Attached patch purple changes WIP v1 (obsolete) (deleted) — — Splinter Review
See bug 1043019, but we have to port the purple/ stuff somewhere too so we can morph this bug.
Attached patch im/ changes v2 (obsolete) (deleted) — — Splinter Review
Attachment #8461219 - Attachment is obsolete: true
Attached patch purple/ changes v2 (obsolete) (deleted) — — Splinter Review
These 2 patches produced a working Mac Debug build. We need to clean them up, see what's Mac-only vs what should apply on all platforms, and make the same changes to mintrayr.
Attachment #8461221 - Attachment is obsolete: true
Attached patch purple/ changes v3 (obsolete) (deleted) — — Splinter Review
Attachment #8461273 - Attachment is obsolete: true
Attachment #8461448 - Flags: review?(clokep)
Comment on attachment 8461448 [details] [diff] [review] purple/ changes v3 Review of attachment 8461448 [details] [diff] [review]: ----------------------------------------------------------------- Looks good overall. I don't like the QQ change, we should probably just disable building it (in a separate patch). People reported recently that it's not working anyway.
Attachment #8461448 - Flags: review?(clokep) → review-
Attached patch im/ changes v3 (deleted) — — Splinter Review
Assignee: nobody → florian
Attachment #8461272 - Attachment is obsolete: true
Attachment #8461475 - Flags: review?(clokep)
Comment on attachment 8461475 [details] [diff] [review] im/ changes v3 Review of attachment 8461475 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, testing this on Linux right now.
Attachment #8461475 - Flags: review?(clokep) → review+
Attached patch purple/ changes v4 (deleted) — — Splinter Review
- Removed the qq change that was here by accident. - Two additional EXTRA_LIBS -> OS_LIBS that are required for building on Windows.
Attachment #8461448 - Attachment is obsolete: true
Attachment #8461563 - Flags: review?(clokep)
Attachment #8461563 - Flags: review?(clokep) → review+
https://hg.mozilla.org/comm-central/rev/1b51a4f02a62 http://hg.mozilla.org/users/florian_queze.net/purple/rev/e69eedb84ede Going to restart nightly builds now. Thanks Florian!
Blocks: 1043019
Status: NEW → RESOLVED
Closed: 10 years ago
Depends on: 1036894
Resolution: --- → FIXED
Attached patch purple/ Linux follow-up (deleted) — — Splinter Review
Attachment #8461753 - Flags: review?(clokep)
Attachment #8461753 - Flags: review?(clokep) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: