Closed Bug 1043108 Opened 10 years ago Closed 10 years ago

Remove arch:IA32 from non-x86 builds

Categories

(Firefox Build System :: General, defect, P2)

Product:
Firefox Build System
Component:
General
Platform:
x86_64
Windows 7
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla34

People

(Reporter: away, Assigned: away)

References

Details

Attachments

(3 files)

NSPR patch
(deleted), patch
away
: review+
Details | Diff | Splinter Review
NSS patch
(deleted), patch
away
: review+
KaiE
: superreview+
Details | Diff | Splinter Review
Top-level and JS configures
(deleted), patch
glandium
: review+
Details | Diff | Splinter Review
(In reply to Vladimir Vukicevic [:vlad] [:vladv] from comment #37) > -arch:IA32 is not valid when doing x64 builds, but configure will now > unconditionally add it. This creates a lot of spam during the build: > > cl : Command line warning D9002 : ignoring unknown option '-arch:IA32' > > We should only add this option when doing 32-bit builds.
How can I detect architecture in the NSS/NSPR builds? I tried testing CPU_ARCH, but it seems that's not the right thing to use. On my win64 build, CPU_ARCH is x386 in NSS and x86 in NSPR.
Flags: needinfo?(wtc)
Attached patch NSPR patch (deleted) — — Splinter Review
David: after inspecting the NSPR configure.in script, I think this is the most convenient place to add the -arch:IA32 flag to x86 builds. An alternative solution is to duplicate the case statement where we currently add the -arch:IA32 flag: case "$target_cpu" in i*86) if test "$MSC_VER" -ge "1700" -a -z "$USE_64"; then dnl Visual C++ 2012 defaults to -arch:SSE2. Use -arch:IA32 dnl to avoid requiring SSE2. CFLAGS="$CFLAGS -arch:IA32" fi ;; esac Which solution do you prefer?
Attachment #8467779 - Flags: review?(dmajor)
Flags: needinfo?(wtc)
Attached patch NSS patch (deleted) — — Splinter Review
Attachment #8467950 - Flags: superreview?(kaie)
Attachment #8467950 - Flags: review?(dmajor)
Attachment #8467950 - Flags: superreview?(kaie) → superreview+
Attachment #8467950 - Flags: review?(dmajor) → review+
Comment on attachment 8467779 [details] [diff] [review] NSPR patch Either approach sounds fine, thanks for the patches!
Attachment #8467779 - Flags: review?(dmajor) → review+
Thanks, I'll add the top-level and JS configures when I get a chance.
Comment on attachment 8467779 [details] [diff] [review] NSPR patch NSPR patch pushed to mozilla-inbound as part of the NSPR_4_10_7_BETA4 tag: https://hg.mozilla.org/integration/mozilla-inbound/rev/cc8cee47432c
Assignee: nobody → wtc
Status: NEW → ASSIGNED
Keywords: leave-open
Priority: -- → P2
Comment on attachment 8467950 [details] [diff] [review] NSS patch NSS patch pushed to mozilla-central as part of the NSS_3_17_BETA2 tag: https://hg.mozilla.org/mozilla-central/rev/07b8619be3bb
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/cc8cee47432c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
We still need the main and JS configure files.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch Top-level and JS configures (deleted) — — Splinter Review
Assignee: wtc → dmajor
Attachment #8472124 - Flags: review?(mh+mozilla)
Attachment #8472124 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/709185909884
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: