Closed Bug 1043284 Opened 10 years ago Closed 10 years ago

Trigger the global search when the app title bar is tapped

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S1 (1aug)

People

(Reporter: etienne, Assigned: etienne)

References

Details

(Whiteboard: [systemsfe][tako])

Attachments

(1 file)

(deleted), text/x-github-pull-request
vingtetun
: review+
kgrandon
: review+
Details
No description provided.
Attached file Gaia PR (deleted) —
r? Vivien for the window manager par r? Kevin for the rocketbar part The PR also includes the commit from bug 1042083 so you can test it (if you have app.theme-color set to true in your settings db)
Assignee: nobody → etienne
Attachment #8461438 - Flags: review?(kgrandon)
Attachment #8461438 - Flags: review?(21)
Comment on attachment 8461438 [details] Gaia PR Not exactly sure what parts I'm supposed to review, but the code generally looks fine. Few things I noticed: 1 - Homescreen statusbar is not transparent when at the top, fix this if you can before landing. 2 - Style of focused rocketbar state is wrong, the text looks too light, the colors off. We can fix this as a follow-up though.
Attachment #8461438 - Flags: review?(kgrandon) → review+
(In reply to Kevin Grandon :kgrandon from comment #2) > Comment on attachment 8461438 [details] > Gaia PR > > Not exactly sure what parts I'm supposed to review, but the code generally > looks fine. Few things I noticed: > > 1 - Homescreen statusbar is not transparent when at the top, fix this if you > can before landing. Mmmhh... I tested all the commits for this. How old is your gecko? The metachange support landed 1-2 weeks ago. > 2 - Style of focused rocketbar state is wrong, the text looks too light, the > colors off. We can fix this as a follow-up though. Fixed! Thanks again for the help with the tests!
(In reply to Etienne Segonzac (:etienne) from comment #3) > (In reply to Kevin Grandon :kgrandon from comment #2) > Mmmhh... I tested all the commits for this. > How old is your gecko? > The metachange support landed 1-2 weeks ago. After testing your branch and updating gecko today everything seemed to work well :) Solid R+ from me :)
Comment on attachment 8461438 [details] Gaia PR r+ with nits and I would like a followup to remove the fade-overlay here and on the homescreen as I don't think they are needed.
Attachment #8461438 - Flags: review?(21) → review+
Blocks: 941182
Whiteboard: [systemsfe]
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe] → [systemsfe][tako]
Target Milestone: --- → 2.1 S1 (1aug)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: