Pooja Reporter
	Description • 10 years ago

Steps to Reproduce:
1. Open camera
2. Switch to Front Camera
3. Keep the device in Landscape mode and take a snapshot
4. Check thumbnail  Or Go to Gallery and check the captured image

Actual behavior:
 Captured image is inverted or rotated by 180 degree

Expected behavior:
 Capture image should be same as that of preview.

Device details:
QRD 8x10 
"gaia 5f8b1b8a2da9e3b531eee817a669f57fa4d9b9c6"
"gecko e00f7e464333689fcf54edb4945ece94f97f930b"
Version 32.0a2
Build Id 20140717155308

	Pooja Reporter
	Comment 1 • 10 years ago

[Blocking Requested - why for this release]:

	Jason Smith [:jsmith]
	Comment 2 • 10 years ago

QA Wanted to see if we can reproduce on Flame.

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 3 • 10 years ago

This does occur on the flame

Gaia      91986777d0942b63e37fbfeec19d69d6176d6d74
Gecko     https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/392054b2e899
BuildID   20140723160206
Version   32.0
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

The preview is also upside down as well as the image when you capture it.

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 4 • 10 years ago

2.0+

Also happens in 2.1.

	Tony Chung [:tchung]
	Comment 5 • 10 years ago

is this a regression from 1.4?

	Tony Chung [:tchung]
	Comment 6 • 10 years ago

qawanted to check on Flame 1.4 if this reproduces.

	Pi Wei Cheng [:piwei] (inactive)
	Comment 7 • 10 years ago

This issue is not reproducible on Flame 1.4. Images taken from front camera are not 180 degrees flipped (upside down). However,

> Expected behavior:
> Capture image should be same as that of preview.

This statement doesn't seem to be true on 1.4. The preview and the final image captured are left and right flipped. So if I have a water bottle in the picture, words on the bottle would appear horizontally flipped in preview/viewfinder (like looking at a mirror), but the captured image would appear normal (words can be read normally).

I've checked on my personal phone which runs Android 4.4.4 and it's the same behavior. So I think this behavior is to be expected.

Tested on:
Device: Flame
Build ID: 20140724070707
Gaia: 6e4eaa5befce9c1812e07bcc78b2138645bdbe7a
Gecko: c55732bd61a2
Version: 30.0 (1.4)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

	Hema Koka [:hema]
	Comment 8 • 10 years ago

(In reply to Pi Wei Cheng [:piwei] from comment #7)
> This issue is not reproducible on Flame 1.4. Images taken from front camera
> are not 180 degrees flipped (upside down). However,
> 
> > Expected behavior:
> > Capture image should be same as that of preview.
> 
> This statement doesn't seem to be true on 1.4. The preview and the final
> image captured are left and right flipped. So if I have a water bottle in
> the picture, words on the bottle would appear horizontally flipped in
> preview/viewfinder (like looking at a mirror), but the captured image would
> appear normal (words can be read normally).
> 
> I've checked on my personal phone which runs Android 4.4.4 and it's the same
> behavior. So I think this behavior is to be expected.
> 
> Tested on:
> Device: Flame
> Build ID: 20140724070707
> Gaia: 6e4eaa5befce9c1812e07bcc78b2138645bdbe7a
> Gecko: c55732bd61a2
> Version: 30.0 (1.4)
> Firmware Version: v122
> User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Left/Right Flip seems to be the behavior for photos taken using front camera on my personal phone as well. 

However, on Flame I am seeing a top/bottom 180 degrees flip with front camera (only on landscape; portrait shows a left/right flip). Mike, any ideas why this is happening?

	Diego Marcos [:dmarcos] Assignee
	Comment 9 • 10 years ago

This is a dup and it's a OEM issue. The pictures in flame don't contain the exif orientation flag.

	Joshua Mitchell (Inactive)
	Comment 10 • 10 years ago

Removing QA-Wanted tags

	Diego Marcos [:dmarcos] Assignee
	Comment 12 • 10 years ago

Reopening. There's actually a bug on the device orientation flag we pass to the camera. Attached PR to master that can be uplifted to 2.0

	bhargavg1
	Comment 13 • 10 years ago

(In reply to Diego Marcos [:dmarcos] from comment #11)
> Created attachment 8462020 [details]
> Pull Request

See this patch fixes the issue, its not upside down any more.

	Justin D'Arcangelo [:justindarc]
	Comment 15 • 10 years ago

Comment on attachment 8462020 [details]
Pull Request

Looks good to me! No more upside-down selfies :-)

	Diego Marcos [:dmarcos] Assignee
	Comment 16 • 10 years ago

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/9c5b09649e937764c2a19177661c9afefa7c981c

It should cleanly uplift to 2.0

	Ryan VanderMeulen [:RyanVM]
	Comment 17 • 10 years ago

v2.0: https://github.com/mozilla-b2g/gaia/commit/f1186d94f344dc725da4c28257281641f83a2ac1

	Yeojin Chung [:YeojinC]
	Comment 18 • 10 years ago

Found Test Case: https://moztrap.mozilla.org/manage/case/2528/

STR needs to added to verify this bug to the existing test case.

	KTucker [:KTucker][Inactive 3/4/2016]
	Comment 19 • 10 years ago

New test case written in moztrap:

https://moztrap.mozilla.org/manage/case/14201/

	Paladin
	Comment 20 • 10 years ago

This issue has been verified successfully on Flame 2.0,2.1

See attachment: Verify_video.3gp
Reproducing rate: 0/5
Flame 2.0 versions:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/29222e215db8
Build-ID        20141203000201
Version         32.0
Flame 2.1 versions:
Gaia-Rev        dbaf3e31c9ba9c3436e074381744f2971e15c7bf
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebce587d2194
Build-ID        20141203001205
Version         34.0