Closed
Bug 1043351
Opened 10 years ago
Closed 10 years ago
ShowSSEConfig is not built
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla34
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 6 obsolete files)
I obviously missed that in bug 894941, which didn't add it back in CPP_UNIT_TESTS.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8461493 -
Flags: review?(mshal)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8461524 -
Flags: review?(mshal)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8461493 -
Attachment is obsolete: true
Attachment #8461493 -
Flags: review?(mshal)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Forgot to move TestZip.cpp.
Attachment #8461531 -
Flags: review?(mshal)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8461524 -
Attachment is obsolete: true
Attachment #8461524 -
Flags: review?(mshal)
|
|
Assignee | |
Comment 4•10 years ago
|
||
And with a path correction
Attachment #8461545 -
Flags: review?(mshal)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8461531 -
Attachment is obsolete: true
Attachment #8461531 -
Flags: review?(mshal)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Sorry for the noise. I just figured the condition could also be lifted, because of the new location.
Attachment #8461547 -
Flags: review?(mshal)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8461545 -
Attachment is obsolete: true
Attachment #8461545 -
Flags: review?(mshal)
|
|
Assignee | |
Comment 6•10 years ago
|
||
The funny thing is that this doesn't build without bug 1043344. Bug interdependency ftw.
|
|
Assignee | |
Comment 7•10 years ago
|
||
And here's a version that doesn't depend on bug 1043344.
Attachment #8461561 -
Flags: review?(mshal)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8461547 -
Attachment is obsolete: true
Attachment #8461547 -
Flags: review?(mshal)
|
|
Assignee | |
Comment 8•10 years ago
|
||
This one is good. Like previous, but with another TEST_TOOL_DIRS.
https://tbpl.mozilla.org/?tree=Try&rev=4524a2930a7f
Attachment #8461614 -
Flags: review?(mshal)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8461561 -
Attachment is obsolete: true
Attachment #8461561 -
Flags: review?(mshal)
|
||
Comment 9•10 years ago
|
||
Comment on attachment 8461614 [details] [diff] [review]
Build ShowSSEConfig as a C++ unit test after it was forgotten in bug 894941 and move linker tests to avoid conflicts
Looks fine to me, and this one seems to build locally for me :)
Attachment #8461614 -
Flags: review?(mshal) → review+
|
|
Assignee | |
Comment 10•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
QA Whiteboard: [qa-]
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•