(not currently active) Ted Mielczarek Reporter
	Description • 10 years ago

There are some error-handling code paths in Mochitest that use log.error. Since the structured logging changes, these get printed as INFO, which means they don't get highlighted on TBPL, and also it's confusing.

Sample (from a patch I'm working on):
log.error('Could not find path to gmp-fake plugin!')

Output produced:
0 INFO Could not find path to gmp-fake plugin!

	Ed Morley [:emorley]
	Comment 1 • 10 years ago

Ah, I guess this might be the cause of at least one of bug 1043428 and bug 1043433.

	Ahmed Kachkach [:akachkach] Assignee
	Comment 2 • 10 years ago

This should do it. (Note that this just for the log level shown after the line number, the one shown before it is added by mozharness).

Example output:

1888 WARNING Warning: webapprt_indexeddb.html from manifest /Users/akachkach/workspace/gecko-dev/obj-x86_64-apple-darwin13.3.0/_tests/testing/mochitest/tests/webapprt/test/content/mochitest.ini is not a valid test
1889 INFO SUITE-START | Running 3649 tests
1890 INFO runtests.py | Running tests: start.

1891 INFO runtests.py | Application pid: 73462
1892 ERROR EXAMPLE ERROR
1893 INFO -*- Webapps.jsm : Saving /var/folders/d8/dn7q5bvx0r3_qwzh8nqy2sr40000gn/T/tmpapUEoa.mozrunner/webapps/webapps.json

	(not currently active) Ted Mielczarek Reporter
	Comment 3 • 10 years ago

Comment on attachment 8461630 [details] [diff] [review]
0001-Bug-1043420-Use-actual-log-level-in-mochitest-logs-i.patch

Review of attachment 8461630 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

	Ahmed Kachkach [:akachkach] Assignee
	Comment 4 • 10 years ago

Did a try push here: https://tbpl.mozilla.org/?tree=Try&rev=695c48aa5cf2

	Carsten Book [:Tomcat]
	Comment 5 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b829e5002fe

	Carsten Book [:Tomcat]
	Comment 6 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/9b829e5002fe

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 10 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/ee1695fc5e0b