Closed
Bug 1043534
Opened 10 years ago
Closed 10 years ago
move netwerk/{sctp,srtp} completely over to moz.build
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla34
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
(deleted),
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
Just a couple easy CFLAGS definitions.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8461716 -
Flags: review?(mshal)
Comment 2•10 years ago
|
||
Comment on attachment 8461716 [details] [diff] [review]
move netwerk/{sctp,srtp} completely over to moz.build
Does this do anything different than the test in configure.in?
if test "$GNU_CC"; then
...
CFLAGS="$CFLAGS -std=gnu99"
At least on my local machine, I get two '-std=gnu99' command-line arguments when compiling things in these directories. We might just be able to remove it from these files entirely.
If it is still necessary for some reason, then r+ since it looks otherwise fine.
Attachment #8461716 -
Flags: review?(mshal) → review+
Assignee | ||
Comment 3•10 years ago
|
||
That's a good point.
I think leaving it in would be better, since all this code is imported third-party stuff and the moz.build is slightly easier to verify if the settings there are close to what the upstream bits have. Our jemalloc Makefiles set -std=gnu99, too, so there is at least some precedent.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → nfroyd
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
QA Whiteboard: [qa-]
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•