Closed Bug 1043534 Opened 10 years ago Closed 10 years ago

move netwerk/{sctp,srtp} completely over to moz.build

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla34

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

Just a couple easy CFLAGS definitions.
Attachment #8461716 - Flags: review?(mshal)
Comment on attachment 8461716 [details] [diff] [review] move netwerk/{sctp,srtp} completely over to moz.build Does this do anything different than the test in configure.in? if test "$GNU_CC"; then ... CFLAGS="$CFLAGS -std=gnu99" At least on my local machine, I get two '-std=gnu99' command-line arguments when compiling things in these directories. We might just be able to remove it from these files entirely. If it is still necessary for some reason, then r+ since it looks otherwise fine.
Attachment #8461716 - Flags: review?(mshal) → review+
That's a good point. I think leaving it in would be better, since all this code is imported third-party stuff and the moz.build is slightly easier to verify if the settings there are close to what the upstream bits have. Our jemalloc Makefiles set -std=gnu99, too, so there is at least some precedent.
Assignee: nobody → nfroyd
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: