Closed
Bug 1043599
Opened 10 years ago
Closed 10 years ago
Show app titlebar after swipe in fullscreen apps
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S1 (1aug)
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Hey Etienne - not sure what you wanted to do here. Would something like this work?
Attachment #8461811 -
Flags: feedback?(etienne)
Comment 2•10 years ago
|
||
Comment on attachment 8461811 [details]
Pull Request
makes sense, comments on github!
Attachment #8461811 -
Flags: feedback?(etienne) → feedback+
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8461811 [details]
Pull Request
Etienne - Ok, I think this is ready for a proper review round now. This does depend on your patch though, so if you want to wait until that lands, that's fine. Or you can review the commit here: https://github.com/KevinGrandon/gaia/commit/65d75585051c0d76f503c75d01e6c555e98bfb24
Attachment #8461811 -
Flags: feedback+ → review?(etienne)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8461811 [details]
Pull Request
Rebasing against Vivien's patch broke stuff again =/ Working on fixing this.
Attachment #8461811 -
Flags: review?(etienne)
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8461811 [details]
Pull Request
Ok - actually it still works, I just needed to change a z-index value of the fullscreen titlebar after Vivien's patch. I changed it to match the same one he applied for titlebar.expanded. Let me know what you think.
Attachment #8461811 -
Flags: review?(etienne)
Comment 6•10 years ago
|
||
Comment on attachment 8461811 [details]
Pull Request
It's shaping up nicely, 2 comments to fix (on github) and we should be good to go!
Attachment #8461811 -
Flags: review?(etienne)
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8461811 [details]
Pull Request
Made a few updates for this round:
1 - I pass in the titleBar element to the _releaseBar method now to ensure we clear the correct bar. I guess it's a bit messy because it's not a sub-component of app window. Seems like we may want to change this in the future :)
2 - Fixed animations to use the same as we do for normal app windows. To do so we just had to position the app titlebar in the same way, and reset the manually set transition style.
3 - Removed show/hide calls. This is now handled in CSS for us (and we basically *always* hide the statusbar across all app windows. I think it's much more clean now.
Since Etienne is on PTO now I believe - I'm going to loop in Vivien/Alive as potential reviewers for this if you guys have the cycles. Thanks!
Attachment #8461811 -
Flags: review?(etienne)
Attachment #8461811 -
Flags: review?(alive)
Attachment #8461811 -
Flags: review?(21)
Comment 8•10 years ago
|
||
Comment on attachment 8461811 [details]
Pull Request
+1 for Cleaning, not very happy about titlebar in statusbar part but we could refine later.
Attachment #8461811 -
Flags: review?(alive) → review+
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8461811 [details]
Pull Request
Thanks Alive. Let's land with your review stamp for now.
Attachment #8461811 -
Flags: review?(etienne)
Attachment #8461811 -
Flags: review?(21)
Assignee | ||
Comment 10•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•