Some follow-on patches for the Apple PlatformDecoderModule.

This is a series of small cleanup patches. Should be quick to review.

Suggestion from Anthony. Doesn't seem to make any difference, but more obviously not a typo than the previous code.

Comment on attachment 8462224 [details] [diff] [review] Part 2: Improve logging Review of attachment 8462224 [details] [diff] [review]: ----------------------------------------------------------------- You may want your own log module separate from the demuxer, as these logs will be very noisy when things are working properly.

I get a lot of dropped frames when I return them in the natural decode order. I assume the playback queue is rejecting the out-of-order frames. The Apple h.264 decoder needs to reorder the frames locally and return them in presentation order. I've filed bug 1043710 to get the real reorder depth from the file, but in the meantime just using a depth of three corrects the problem for most files.

Vim paste error in the copyright header.

https://hg.mozilla.org/integration/mozilla-inbound/rev/18d6d559e00b https://hg.mozilla.org/integration/mozilla-inbound/rev/a140fa9605f0 https://hg.mozilla.org/integration/mozilla-inbound/rev/c62d33eb57d3 https://hg.mozilla.org/integration/mozilla-inbound/rev/26b80b058cd2 https://hg.mozilla.org/integration/mozilla-inbound/rev/dc0fbe8b84d2

https://hg.mozilla.org/mozilla-central/rev/18d6d559e00b https://hg.mozilla.org/mozilla-central/rev/a140fa9605f0 https://hg.mozilla.org/mozilla-central/rev/c62d33eb57d3 https://hg.mozilla.org/mozilla-central/rev/26b80b058cd2 https://hg.mozilla.org/mozilla-central/rev/dc0fbe8b84d2