nsIWebProgressListener should contain status flags to indicate that tracking content has been detected and blocked or detected and loaded anyway. Element loaders should utilize those flags to emit corresponding security events.

Comment on attachment 8462935 [details] [diff] [review] extended nsIWebProgressListener with tracking protection events, modified script, image, object and frame loaders to emit such events Review of attachment 8462935 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/base/src/nsImageLoadingContent.cpp @@ +176,2 @@ > /* Handle image not loading error because source was a tracking URL. > * (Safebrowinsg) We make a note of this image node by including it delete Safebrowsing ::: content/base/src/nsScriptLoader.cpp @@ +1410,3 @@ > /* > * Handle script not loading error because source was a tracking URL. > * (Safebrowinsg) We make a note of this script node by including it spelling Safebrowsing Just get rid of Safebrowsing

Comment on attachment 8467480 [details] [diff] [review] extended nsIWebProgressListener with tracking protection events and modified script, image, object, style and frame loaders to emit such events Review of attachment 8467480 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/base/src/nsImageLoadingContent.cpp @@ +184,5 @@ > nsIDocument *doc = GetOurOwnerDoc(); > doc->AddBlockedTrackingNode(thisNode); > > doc->SetHasTrackingContentBlocked(true); > + Should this happen in nsChannelClassifier, similar to https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1047705&attachment=8467901? That would allow you to avoid touching the loaders and consolidate adding STATE_BLOCKED_TRACKING_CONTENT to the docshell state in a single place.

Comment on attachment 8469428 [details] [diff] [review] extended nsIWebProgressListener with tracking protection events We need to introduce tracking protection events in the progress listener so we can notify the UI (previously mixed content doorhanger)

Comment on attachment 8469428 [details] [diff] [review] extended nsIWebProgressListener with tracking protection events But I'd like see (not necessarily really review) the patch using these flags.

https://bugzilla.mozilla.org/show_bug.cgi?id=1050348 https://bugzilla.mozilla.org/show_bug.cgi?id=1047705