Closed Bug 1044445 Opened 10 years ago Closed 10 years ago

Collapse test-only moz.build files under content/ into ancestor moz.build files

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla34

People

(Reporter: poiru, Assigned: poiru)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

Collapse test-only moz.build files under content/ into ancestor moz.build files
(deleted), patch
glandium
: review+
Details | Diff | Splinter Review
Collapse test-only moz.build files under content/media/ into ancestor moz.build files
(deleted), patch
glandium
: review+
Details | Diff | Splinter Review
Similar to bug 1043963.
Comment on attachment 8463002 [details] [diff] [review] Collapse test-only moz.build files under content/media/ into ancestor moz.build files Review of attachment 8463002 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/media/moz.build @@ -55,4 @@ > > -TEST_DIRS += [ > - 'test', > - 'gtest', I think you lost gtest
Comment on attachment 8463003 [details] [diff] [review] Collapse test-only moz.build files under content/ into ancestor moz.build files Review of attachment 8463003 [details] [diff] [review]: ----------------------------------------------------------------- Note this patch is bitrotted.
Attachment #8463003 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8463002 [details] [diff] [review] Collapse test-only moz.build files under content/media/ into ancestor moz.build files Review of attachment 8463002 [details] [diff] [review]: ----------------------------------------------------------------- Note this patch is bitrotted. ::: content/media/moz.build @@ -55,4 @@ > > -TEST_DIRS += [ > - 'test', > - 'gtest', What Ms2ger says.
Attachment #8463002 - Flags: review?(mh+mozilla) → feedback+
(In reply to Mike Hommey [:glandium] from comment #5) > Comment on attachment 8463002 [details] [diff] [review] > Collapse test-only moz.build files under content/media/ into ancestor > moz.build files > > Review of attachment 8463002 [details] [diff] [review]: > ----------------------------------------------------------------- > > Note this patch is bitrotted. > > ::: content/media/moz.build > @@ -55,4 @@ > > > > -TEST_DIRS += [ > > - 'test', > > - 'gtest', > > What Ms2ger says. Fixed and rebased.
Attachment #8463002 - Attachment is obsolete: true
Attachment #8464014 - Flags: review?(mh+mozilla)
Attachment #8464014 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/4e835a9ab6bb https://hg.mozilla.org/mozilla-central/rev/d84bafd55697
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: