Closed Bug 1044508 Opened 10 years ago Closed 7 years ago

[Keyboard] Stop using HTML in layout definition for 全/半 button

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: timdream, Assigned: wdeng)

References

Details

Attachments

(1 file)

(deleted), text/x-github-pull-request
Details
The 全/半 button is currently defined with HTML present in layout definition. We should generalized this into render.js or layout manager or somewhere better just like every other keys since they are used in two places (bug 1021505 and bug 938039).
:rudyl, please add this to the roadmap.
Flags: needinfo?(rlu)
Assignee: nobody → wdeng
For the math virtual keyboard (Bug 1004057) I need to use HTML (more specific MathML) for some keys to ensure that the user will get the properly render. Some examples are: - subscript and superscript: <math><msubsup><mi>x</mi><mi>y</mi><mi>z</mi></msubsup></math> - n-root: <math><mroot><mi>x</mi><mi>n</mi></mroot></math> - absolute value: <math><mrow><mo>|</mo><mi>x</mi><mo>|</mo></mrow></math> - matrices: <math><mtable><mtr><mtd><mi>a</mi></mtd><mtd><mi>b</mi></mtd></mtr></mtable></math> - hats: <math><mover><mi>x</mi><mo>^</mo></mover></math> Any alternative?
Blocks: 1004057
Attached file pull request 22770 (deleted) —
Hi Tim, Do you have time take a look? Thanks
Attachment #8472228 - Flags: review?(timdream)
Comment on attachment 8472228 [details] pull request 22770 I don't think this patch is good enough because it simply moves the special case handling from layouts to render.js. That said, I don't have better alternatives when I try to think of a better approach. If there isn't a better way to solve this bug and we have more use case like comment 3, maybe this bug should be closed as invalid.
Attachment #8472228 - Flags: review?(timdream)
Agree. Situations like comment 3, I prefer to put them in a single layout file. (In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #5) > Comment on attachment 8472228 [details] > pull request 22770 > > I don't think this patch is good enough because it simply moves the special > case handling from layouts to render.js. That said, I don't have better > alternatives when I try to think of a better approach. > > If there isn't a better way to solve this bug and we have more use case like > comment 3, maybe this bug should be closed as invalid.
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: