Closed
Bug 1044550
Opened 10 years ago
Closed 10 years ago
Move GMP Shmem cache from global to per-GMPParent
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(firefox33 fixed, firefox34 fixed)
RESOLVED
FIXED
mozilla34
People
(Reporter: jesup, Assigned: jesup)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
cpearce
:
review+
nical
:
feedback+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The GMP cache is global right now, but the Shmems are only shared with a specific GMPParent/plugin. Move the data storage to the GMPParent while leaving the impl in the GMPVideoEncoder/etc - The Alloc/FreeShmem's are only defined at that level. Also adjust a few constants, and cleanup.
Assignee | ||
Updated•10 years ago
|
Whiteboard: [openh264-uplift]
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8463082 -
Flags: review?(cpearce)
Attachment #8463082 -
Flags: feedback?(nical.bugzilla)
Assignee | ||
Comment 2•10 years ago
|
||
Note: applies on top of bug 1043531's patch
Updated•10 years ago
|
Attachment #8463082 -
Flags: review?(cpearce) → review+
Updated•10 years ago
|
Attachment #8463082 -
Flags: feedback?(nical.bugzilla) → feedback+
Assignee | ||
Comment 3•10 years ago
|
||
Target Milestone: --- → mozilla34
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8463082 [details] [diff] [review]
Move GMP shared mem cache from a global to per-GMPParent
Approval Request Comment
[Feature/regressing bug #]: 1020090
[User impact if declined]: Hopefully none.
[Describe test coverage new/current, TBPL]: GMP plugin tests are in m-c and ready to land on Aurora.
[Risks and why]: If declined, less similarity between Aurora and Nightly, where most of the testing and fixes are generated. Similar code reduces the risk of diverging bugs during this feature-polishing/release phase, where heavy QA is going on. It also eases uplifting any bugfixes. It *should* be ok without this patch, as with a single plugin this should work the same as without the patch - but we haven't tested without it.
[String/UUID change made/needed]: none
Attachment #8463082 -
Flags: approval-mozilla-aurora?
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
status-firefox33:
--- → affected
status-firefox34:
--- → fixed
Updated•10 years ago
|
Attachment #8463082 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 6•10 years ago
|
||
Whiteboard: [openh264-uplift]
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•