Comment on attachment 8463129 [details] [diff] [review] Fix more bad implicit conversion constructors in the JS engine Review of attachment 8463129 [details] [diff] [review]: ----------------------------------------------------------------- Great, thanks again. r=me with the change listed below. ::: js/src/vm/SavedStacks.cpp @@ +73,5 @@ > > class SavedFrame::HandleLookup > { > public: > + explicit HandleLookup(SavedFrame::AutoLookupRooter &lookup) : ref(lookup) { } This is another handle class --- please do not make this particular conversion explicit. @@ +548,5 @@ > stackState[i-1].location.column, > stackState[i-1].name, > parentFrame, > stackState[i-1].principals); > + parentFrame.set(getOrCreateSavedFrame(cx, SavedFrame::HandleLookup(lookup))); ...and please undo the corresponding change here.