Florian Quèze [:florian] Reporter
	Description • 10 years ago

Steps to reproduce:
1. In about:config, set devtools.chrome.enabled to true
2. In the main browser window's menubar: Tools -> Web Developer -> Scratchpad
3. In the scratchpad's menubar: Environment -> Browser
4. Paste this in the scratch pad:
let win = Services.ww.openWindow(null, "chrome://browser/content/browser.xul", "", "", null);
win.addEventListener("load", function() {
  setTimeout(function() {
    win.minimize();
      win.focus();
  }, 2000);
});
5. Select the pasted code and press Command+R to execute it.

Expected behavior:
A window opens, 2 seconds later it is minimized and then restored.

Actual behavior:
When the window is restored, the 'restore' animation happens, then the window disappears, and the animation that happens for new windows (when pressing Command+N on a browser window) happens.

Note: It's possible to workaround the issue with this JS code:
if (win.windowState == win.STATE_MINIMIZED)
  win.restore();
else
  win.focus();
but this really seems like a platform issue.

The code above is a reduced test case from bug 1042542.

	Neil Deakin Assignee
	Comment 1 • 10 years ago

This issue also happens with the downloads panel. Open the panel and then try to minimize the window and you'll get the behaviour above.

	Neil Deakin Assignee
	Comment 2 • 10 years ago

This seems to fix the flickering issue.

	Neil Deakin Assignee
	Comment 3 • 10 years ago

This part fixes when panels unminimize the window when they are closed.

	Marco Mucci [:MarcoM]
	Comment 4 • 10 years ago

Hi Neil, can you provide a point value and if the bug should be marked as [qa+] or [qa-] for verificaiton.

	Neil Deakin Assignee
	Comment 5 • 10 years ago

This can be tested using both of:

1. The steps in the initial comment.

2. These steps:
 - Open a new tab and load some page.
 - Click on the blank area of the page such that no specific element is focused
 - Open the downloads panel from the toolbar
 - Minimize the window

The window should stay minimized and not flicker.

	Dão Gottwald [:dao]
	Comment 6 • 10 years ago

Comment on attachment 8471013 [details] [diff] [review]
Part 2: fix panels unminimizing when they are closed

Can we just not set _prevFocus to a window in the first place? The popupshowing handler already has a branch using document.activeElement. If we used that instead of document.commandDispatcher.focusedWindow, the content area would be focused without the window being restored if minimized.

	Steven Michaud [:smichaud] (Retired)
	Comment 7 • 10 years ago

Comment on attachment 8471010 [details] [diff] [review]
Part 1: call deminiaturize first when focusing

Weird that this is necessary, but I can't see any harm in it.

(Note that I haven't tested this patch.)

	Neil Deakin Assignee
	Comment 8 • 10 years ago

Like so?

	Neil Deakin Assignee
	Comment 9 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/cee63e83abfb
https://hg.mozilla.org/integration/mozilla-inbound/rev/01a1476ba31b

	Ed Morley [:emorley]
	Comment 10 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/cee63e83abfb
https://hg.mozilla.org/mozilla-central/rev/01a1476ba31b

	Ada [:adalucinet]
	Comment 11 • 10 years ago

Reproduced with Nightly 2014-07-28 with str from comment 0 and comment 5.
Verified as fixed with Firefox 34 beta 7 (Build ID: 20141106201515) on Mac OS X 10.9.5.