Closed Bug 1045237 Opened 10 years ago Closed 5 years ago

Event listeners popup "Open in debugger" doesn't work for prettyprinted scripts

Categories

(DevTools :: Debugger, defect, P3)

Product:
DevTools
Component:
Debugger
Version:
34 Branch
Platform:
x86_64
Linux
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1578752

People

(Reporter: mahdi, Unassigned)

References

Details

(Whiteboard: [polish-backlog])

Attachments

(1 obsolete file) 

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:34.0) Gecko/20100101 Firefox/34.0 (Beta/Release)
Build ID: 20140728042654

Steps to reproduce:

1. Add an event listener in a line, but not the first
2. Minify your script and include
3. Inspect and select visual events, then "Open in Debugger"


Actual results:

Debugger opens, beautifies the script and cursor stays at first line.


Expected results:

Cursor should navigate to the handler after beautifying the script.

An example: http://dibaiee.ir/up/ve/
Component: Untriaged → Developer Tools: Debugger
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assuming that beautifying is the same as pretty printing here.
Blocks: dbg-prettyprint
Summary: Visual events "open in debugger" doesn't work on beautified scripts → "Open in debugger" doesn't work for prettyprinted scripts
Summary: "Open in debugger" doesn't work for prettyprinted scripts → Event listeners popup "Open in debugger" doesn't work for prettyprinted scripts
Whiteboard: [devedition-40]
Priority: -- → P2
Whiteboard: [devedition-40] → [polish-backlog]
Product: Firefox → DevTools
Priority: P2 → P3
Attached file Use column numbers in Event Inspector (wip) (obsolete) (deleted) —

Since pretty-printing produces source maps, this should just work for prettified sources and everything else.

The column numbers for pretty sources are always 0. I think this is a function of the maps generated by pretty-fast, which map source spans to whole lines. I don't think that's an issue but I'm not sure whether to hide the column numbers or not.

Attachment #9100617 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: