Closed
Bug 1045617
Opened 10 years ago
Closed 10 years ago
move {storage,bagheera}-server rules into mach
Categories
(Cloud Services :: Firefox: Common, defect)
Cloud Services
Firefox: Common
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla34
People
(Reporter: froydnj, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
We shouldn't have these sorts of rules in Makefiles; mach should be used for starting utility services like this.
If they're not needed anymore, maybe we can just remove them?
Assignee | ||
Comment 1•10 years ago
|
||
Apologies in advance: this doesn't apply cleanly on m-c, as it's based off some
previous patches for services/ I have in my queue. But those patches don't
materially affect what I'm doing here. (This is also a low priority review,
nothing much depends on this.)
I've moved things into mach and things seem to work, with a couple caveats:
- Just executing $objdir/dist/bin/xpcshell isn't sufficient; there are library
paths that need to be setup (maybe not on Windows?). I think the
run-mozilla.sh script addition should handle this.
- xpcshell apparently lost support for -n...well, a while ago. So if anybody
has been using these rules, I don't understand how. I've removed the -n in
my port, but...
- The server doesn't seem to get past the Cu.import lines in the respective .js
files. I disclaim all responsibility as to this; I don't think it's any more
broken than it was before.
If this is all unused, then I'm more than happy to just nuke everything.
Attachment #8464991 -
Flags: review?(gps)
Comment 2•10 years ago
|
||
Comment on attachment 8464991 [details] [diff] [review]
move services's run_server.py Makefile rules into mach
Review of attachment 8464991 [details] [diff] [review]:
-----------------------------------------------------------------
Aside from the dummy command, LGTM.
There is a slight chance we don't need at least one of these servers any more. But we can always remove the code later.
::: services/common/tests/mach_commands.py
@@ +112,5 @@
> + rmtree(profile_dir)
> +
> + @Command('doesthiswork', category='testing', description='Example command')
> + def doesthiswork(self):
> + print 'hi!'
O hai!
Attachment #8464991 -
Flags: review?(gps) → review+
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → nfroyd
Comment 3•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Comment 4•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•