Closed Bug 1045743 Opened 10 years ago Closed 10 years ago

Add support for the Promise<> syntax in Web IDL bindings

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file, 1 obsolete file)

      No description provided.
Attachment #8464404 - Flags: review?(khuey)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Whiteboard: [need review]
Comment on attachment 8464404 [details] [diff] [review]
Add support for the Promise<type> syntax to Web IDL bindings

>--- a/dom/webidl/BluetoothDevice2.webidl
>+++ b/dom/webidl/BluetoothDevice2.webidl
>@@ -36,10 +36,10 @@ interface BluetoothDevice : EventTarget
>   // Promise<sequence<DOMString>>
>   [NewObject, Throws]
>-  Promise                                   fetchUuids();
>+  Promise<sequence<DOMString>>              fetchUuids();

Forgot to remove the comment?
> Forgot to remove the comment?

Er, yes.
Attached patch Updated to tip (deleted) — Splinter Review
As expected, this bitrots every day.  :(
Attachment #8465389 - Flags: review?(khuey)
Attachment #8464404 - Attachment is obsolete: true
Attachment #8464404 - Flags: review?(khuey)
Comment on attachment 8465389 [details] [diff] [review]
Updated to tip

Review of attachment 8465389 [details] [diff] [review]:
-----------------------------------------------------------------

Is there a plan to make this more than just self-documenting IDL?
Attachment #8465389 - Flags: review?(khuey) → review+
Not so far, though if people come up with a clever way to use this, so much the better.
Thanks for the quick review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/4685bb81ef6d
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla34
> Not so far, though if people come up with a clever way to use this, so much the better.

Er, I lie of course!  I'm using this in bug 1017988 to make sure that a method exposed in global X does not return a Promise<Foo> where Foo is not exposed in global X.
https://hg.mozilla.org/mozilla-central/rev/4685bb81ef6d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: