Closed Bug 1045757 Opened 10 years ago Closed 10 years ago

Status bar / rocketbar visual regression

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set
normal

Tracking

(b2g-v2.0 unaffected, b2g-v2.1 affected)

RESOLVED WORKSFORME
Tracking Status
b2g-v2.0 --- unaffected
b2g-v2.1 --- affected

People

(Reporter: daleharvey, Assigned: mikehenrty)

References

Details

(Whiteboard: [systemsfe])

Attachments

(2 files)

https://github.com/mozilla-b2g/gaia/commit/8abddb42a444dd165332e6642133932a04020b50 cause small regressions on the display of the statusbar and rocketbar
Taking some screenshots
Attached image rocketbar (deleted) —
This should be in the same position as on the homescreen
Attached image statusbar (deleted) —
The statusbar is lighter than it should be
[Blocking Requested - why for this release]: The regression was landed in bug 1038988, and it looks quite unprofessional. My hope is to have a patch for this today.
Assignee: nobody → mhenretty
Blocks: 1038988
blocking-b2g: --- → 2.0?
Whiteboard: [systemsfe]
In commit [1], we hide the statusbar background for the homescreen. This makes my opacity change not work. Fortunately, this was not uplifted to 2.0. I'm checking now on 2.0 if the rocketbar search position is effected on 2.0. If not, we don't need to uplift this bug.
blocking-b2g: 2.0? → 2.0+
This issue doesn't occur on 2.0 with my patch applied. It's from the conflict between [1] from bug 1043272, which will not be uplifted. Clearing blocking flag.

1.) https://github.com/mozilla-b2g/gaia/commit/500ebd79331a50f67e59e4aa0d6dc23af2e5387a#diff-19076406e0c835797eb201e0143532c7L24
blocking-b2g: 2.0+ → ---
Do we need this fixed on 2.1 instead, since that patch is present on 2.1?
Flags: needinfo?(mhenretty)
(In reply to Jason Smith [:jsmith] - At Work Week, Slow to Respond from comment #7)
> Do we need this fixed on 2.1 instead, since that patch is present on 2.1?

We will once bug 1038988 lands again, yes.
Flags: needinfo?(mhenretty)
Let's close this, since bug 1038988 will need rework before land, and we will make sure we don't see this same visual regression there.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: