Closed Bug 1045895 Opened 10 years ago Closed 6 years ago

replace GetParentStyleContextFrame in ElementRestyler::Restyle with an outparam got from RestyleSelf

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID
Milestone:
mozilla35

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file, 1 obsolete file)

patch v2
(deleted), patch
dbaron
: review+
Details | Diff | Splinter Review
Attached patch patch (obsolete) (deleted) — — Splinter Review 
Assignee: nobody → cam
Status: NEW → ASSIGNED

        Attachment #8486891 -
        Flags: review?(dbaron)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v2 (deleted)
        — 
          — Splinter Review
      

    


  
A patch that doesn't assert.

        Attachment #8486891 -
        Attachment is obsolete: true

        Attachment #8486891 -
        Flags: review?(dbaron)

        Attachment #8486979 -
        Flags: review?(dbaron)

    
    

    
  
Comment on attachment 8486979 [details] [diff] [review]
patch v2

>+  if (*aProviderFrame && *aProviderFrame != providerFrame) {
>+    LOG_RESTYLE_CONTINUE("we had different provider frame from the previous "
>+                         "same-style continuation");
>+    result = eRestyleResult_Continue;
>+  }


I don't understand why you're hitting this case, but r=dbaron, I guess.

        Attachment #8486979 -
        Flags: review?(dbaron) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/88d6381ad5d1
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Depends on: 1070759

    
    

    
  
Backed out for causing bug 1070759.

https://hg.mozilla.org/integration/mozilla-inbound/rev/24b61af1917e
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
ElementRestyler is gone.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 6 years ago
Resolution: --- → INVALID

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: