This patch goes on top of bug 1039519 and bug 1045656 and is the beginning of the code needed in order to change the statusbar icons color from bright to dark when the theme-color is bright. But in this patch I only activate it for the system browser as it results already into some CSS changes and tons of images added.

Comment on attachment 8464665 [details] [diff] [review] bug1046099.patch Let's ask a review for this one as well.

Comment on attachment 8464665 [details] [diff] [review] bug1046099.patch Review of attachment 8464665 [details] [diff] [review]: ----------------------------------------------------------------- Seemed to be a fair amount of conflicts here, and I want to make sure I'm testing the right thing. Can you rebase this so I can be sure I test the right thing? Thanks!

Should be easier to apply.

Vivien - the changes to chrome.css are still not lining up to what's in master. Are you sure you did a proper rebase? Everytime I apply the patch there's lots of errors, and for example master does not have 'will-change' set in the first ruleset. Can you please rebase and test against master?

(In reply to Kevin Grandon :kgrandon from comment #5) > Vivien - the changes to chrome.css are still not lining up to what's in > master. Are you sure you did a proper rebase? Everytime I apply the patch > there's lots of errors, and for example master does not have 'will-change' > set in the first ruleset. > > Can you please rebase and test against master? Did I forgot to say that this one is on top of the 2.4rem to 3rem conversion ? :)

(In reply to Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) from comment #6) > Did I forgot to say that this one is on top of the 2.4rem to 3rem conversion > ? :) I see that in the first comment now, but it's hard to track patch dependencies across multiple bugs. Pull requests are easier for this because you can have multiple commits in a pull request ;-) I'll apply it again and test.

(In reply to Kevin Grandon :kgrandon from comment #7) > (In reply to Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, > needinfo? please) from comment #6) > > Did I forgot to say that this one is on top of the 2.4rem to 3rem conversion > > ? :) > > I see that in the first comment now, but it's hard to track patch > dependencies across multiple bugs. Pull requests are easier for this because > you can have multiple commits in a pull request ;-) I'll apply it again and > test. I have landed the dependency now :) In fact I don't expect people to have the time to try my patch! If so, everything is in the smooth.animation.all branch :)

Comment on attachment 8465515 [details] [diff] [review] browser-color.patch Review of attachment 8465515 [details] [diff] [review]: ----------------------------------------------------------------- Took a look and it seems fine to me. Thanks!