Closed
Bug 1046330
Opened 10 years ago
Closed 10 years ago
[Rocketbar] App title does not appear after a swipe in fullscreen apps
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S2 (15aug)
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Keywords: regression, Whiteboard: [systemsfe])
Attachments
(1 file)
A regression from bug 1039519, but let's fix it in place.
Assignee | ||
Comment 1•10 years ago
|
||
Vivien - previously we were just animating the .titlebar element, but it looks like the title has been moved out and placed in the .chrome container now. Any preference as to how to solve this?
I supposed we could either try to nest the elements in a common container, or try translating both elements at the same time.
Flags: needinfo?(21)
Comment 2•10 years ago
|
||
(In reply to Kevin Grandon :kgrandon from comment #0)
> A regression from bug 1039519, but let's fix it in place.
Do you think we need to block on this for 2.1?
Flags: needinfo?(kgrandon)
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Jason Smith [:jsmith] - At Work Week, Slow to Respond from comment #2)
> (In reply to Kevin Grandon :kgrandon from comment #0)
> > A regression from bug 1039519, but let's fix it in place.
>
> Do you think we need to block on this for 2.1?
I don't think it's necessary to block, but we are going to fix it. This stuff is really turbulent right now, so I'd just call this feature work.
Flags: needinfo?(kgrandon)
Assignee | ||
Comment 4•10 years ago
|
||
Hey Vivien - Could you review this patch? It's not perfect as there's no transitions, but it at least shows the titlebar, and we will work on transitions next.
Attachment #8467412 -
Flags: review?(21)
Flags: needinfo?(21)
Updated•10 years ago
|
Target Milestone: 2.1 S1 (1aug) → 2.1 S2 (15aug)
Comment 5•10 years ago
|
||
Comment on attachment 8467412 [details]
Github pull request
r+ with nits. Thanks for fixing it.
Attachment #8467412 -
Flags: review?(21) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•