Closed Bug 1046588 Opened 10 years ago Closed 10 years ago

In RILContentHelper::selectNetwork(), dispatchFireRequestError takes two arguments actually

Categories

(Firefox OS Graveyard :: RIL, defect)

Product:
Firefox OS Graveyard
Component:
RIL
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 843452

People

(Reporter: vicamo, Unassigned)

Details

http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/RILContentHelper.js#703

It is now:

  this.dispatchFireRequestError(RIL.GECKO_ERROR_INVALID_PARAMETER);

Should have been:

  this.dispatchFireRequestError(requestId, RIL.GECKO_ERROR_INVALID_PARAMETER);
(In reply to Vicamo Yang [:vicamo][:vyang] from comment #0)
> http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/
> RILContentHelper.js#703
> 
> It is now:
> 
>   this.dispatchFireRequestError(RIL.GECKO_ERROR_INVALID_PARAMETER);
> 
> Should have been:
> 
>   this.dispatchFireRequestError(requestId,
> RIL.GECKO_ERROR_INVALID_PARAMETER);

The code will be removed in bug 843452. As that is almost ready, close this as DUPLICATE.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.