Closed
Bug 1047022
Opened 10 years ago
Closed 10 years ago
Sort out the manual addref done in the mediarecorder code
Categories
(Core :: Audio/Video: Recording, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: ehsan.akhgari, Assigned: bechen)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
bechen
:
review+
|
Details | Diff | Splinter Review |
Follow-up to bug 1044598 comment 22.
Ben, are you interested in taking this please? Thanks! :-)
|
Reporter | |
Updated•10 years ago
|
Flags: needinfo?(bechen)
|
Assignee | |
Comment 1•10 years ago
|
||
Sorry for late response, I'll take it, thanks.
Assignee: nobody → bechen
Flags: needinfo?(bechen)
|
|
Assignee | |
Comment 2•10 years ago
|
||
In order to remove the manaul addref for Session object, the patch change
|nsTArray<Session*> mSessions| to |nsTArray<nsRefPtr<Session> > mSessions|.
Make a cycle reference between MediaRecorder and Session. The cycle will be break at DestroyRunnable() by calling BreakCycle(). And since the Session object now is really refcounted, we can destroyed it at any thread, not main thread only.
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8472134 -
Flags: review?(roc)
Attachment #8472134 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
r=roc
try server: https://tbpl.mozilla.org/?tree=Try&rev=ec246a5e4f28
I will re-trigger the mochitest-3 to ensure the patch passes all tests.
Attachment #8472134 -
Attachment is obsolete: true
Attachment #8474339 -
Flags: review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 4•10 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•