Closed Bug 1047121 Opened 10 years ago Closed 10 years ago

LSAN leaks when sharing windows via getUserMedia

Categories

(Core :: WebRTC: Audio/Video, defect)

Product:
Core
Component:
WebRTC: Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla34
Tracking Flags:
Tracking Status
firefox33 --- fixed
firefox34 --- fixed

People

(Reporter: jesup, Assigned: jesup)

References

Details

(Keywords: memory-leak)

Attachments

(1 file)

Release Window-capture VideoEngine when done; clean up shutdown code
(deleted), patch
cpearce
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review
The window-sharing code wasn't freeing up the VideoEngine when exiting. This led to LSAN leaks that were unnoticed due to leak-checking being broken. https://tbpl.mozilla.org/?tree=Try&rev=24f65d372a31 for the patch that fixes it.
Attachment #8465855 - Flags: review?(cpearce)
Attachment #8465855 - Flags: review?(cpearce) → review+
Comment on attachment 8465855 [details] [diff] [review] Release Window-capture VideoEngine when done; clean up shutdown code Approval Request Comment [Feature/regressing bug #]: screensharing (master bug alias) [User impact if declined]: Significant leaks in LSAN (a webrtc VideoEngine and related items) which would need to be added to suppression files. [Describe test coverage new/current, TBPL]: LSAN tests in the tree will trigger on this now that screen/window sharing tests are active. [Risks and why]: extremely low; just adds proper cleanup in the same pattern as existing cleanups. [String/UUID change made/needed]: none
Attachment #8465855 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/715b0aee4246
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #8465855 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: