Closed
Bug 1047227
Opened 10 years ago
Closed 10 years ago
Lightning 3.3 no event cancellation button
Categories
(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.3.1
People
(Reporter: malcolmrmclean, Assigned: MakeMyDay)
References
Details
Attachments
(3 files)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
patch
|
Fallen
:
review+
Fallen
:
approval-calendar-aurora+
Fallen
:
approval-calendar-beta+
Fallen
:
approval-calendar-esr+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 (Beta/Release)
Build ID: 20140722195627
Steps to reproduce:
Upgrade to latest Thunderbird 31 and Lightning 3.3 and received an event cancellation.
Even after disabling all other addons, the Delete button still does not appear, so this isn't a conflict with another addon.
Actual results:
No Delete button appears to remove event from calendar as with Thunderbird 26 and Lightning 2.6.x. Buttons for new events and updates display as expected, however event cancellations to not.
Expected results:
A Delete button should appear when receiving an event cancellation.
Reporter | ||
Updated•10 years ago
|
Version: unspecified → Lightning 3.1
Reporter | ||
Comment 1•10 years ago
|
||
Reporter | ||
Comment 2•10 years ago
|
||
Comment 3•10 years ago
|
||
Do you get any error messages in Tools > Error Console?
Version: Lightning 3.1 → Lightning 3.3
Comment 4•10 years ago
|
||
I can confirm this bug, experiencing the same problem.
Reporter | ||
Comment 5•10 years ago
|
||
No errors at all. Even had the console open when a new event cancellation came in and no errors.
Assignee | ||
Comment 6•10 years ago
|
||
Confirming. The fix is simple here - the button is simply aclled with the wrong identifier.
Requesting also an approval for backporting to all branches.
Assignee: nobody → makemyday
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8466632 -
Flags: review?(philipp)
Updated•10 years ago
|
Attachment #8466632 -
Flags: review?(philipp) → review+
Updated•10 years ago
|
Target Milestone: --- → 3.3.1
Assignee | ||
Comment 7•10 years ago
|
||
Philipp, what about also backporting to aurora and beta?
Keywords: checkin-needed
Reporter | ||
Comment 8•10 years ago
|
||
I can confirm that applying the patch locally on 3.3 brings the Delete button back on event cancellations.
Is there perhaps an eta on when 3.3.1 will be available?
Comment 9•10 years ago
|
||
Comment on attachment 8466632 [details] [diff] [review]
FixDeleteInvitationButton-V1.diff
Review of attachment 8466632 [details] [diff] [review]:
-----------------------------------------------------------------
Oh yes, the approvals. Here you go.
3.3.1 release should be (3.3 release date + ( n * 6 weeks) + a few days) where n depends on the number of patches that accumulate and the severity of the already applied patches.
Attachment #8466632 -
Flags: approval-calendar-release+
Attachment #8466632 -
Flags: approval-calendar-beta+
Attachment #8466632 -
Flags: approval-calendar-aurora+
Comment 10•10 years ago
|
||
Pushing so this can get picked up by the release builds:
https://hg.mozilla.org/releases/comm-esr31/rev/d5d90baf34ec
Comment 12•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/5e34658ee5c0
https://hg.mozilla.org/releases/comm-aurora/rev/3a73a2988e74
https://hg.mozilla.org/releases/comm-beta/rev/b74b11923934
This patch will not be in 3.4, but given its not a major release and the cycle is long gone, I'm not going to fix it there.
You need to log in
before you can comment on or make changes to this bug.
Description
•