nsAFlatCString::operator[] doesn't compile on gcc3. I think this is true of other compilers too, and it has caused bustage in the past, but I couldn't find a bug. The problem is a signed/unsigned issue: /builds/cleanup/mozilla/gfx/src/nsColor.cpp:76: ambiguous overload for `NS_LossyConvertUCS2toASCII& [int&]' operator /builds/cleanup/mozilla/gfx/src/nsColor.cpp:76: candidates are: operator[](const char*, int) <builtin> ../../dist/include/string/nsAFlatString.h:56: char nsAFlatCString::operator[](unsigned int) const

jag, you fix this with the removal of implicit conversion, right? (For everything except nsXPIDL[C]String, that is.)

Yeah.

giving up ancient string bugs to the new string owner. jag, you'll want to sort through these and see which ones still apply and go with or against the direction in which you intend strings evolve