Closed
Bug 1047311
Opened 10 years ago
Closed 10 years ago
Change the set of colors based on the brightness of the theme-color
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Firefox OS Graveyard
Gaia::System
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: vingtetun, Assigned: vingtetun)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
kgrandon
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•10 years ago
|
Blocks: rocketbar-dogfood
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8466116 [details] [diff] [review]
theme-color.brightness.settings.patch
Review of attachment 8466116 [details] [diff] [review]:
-----------------------------------------------------------------
Even with both patches I think the contrast of the text inside the rocketbar is a bit hard to read, but I think this is fine to land for now.
Attachment #8466116 -
Flags: review?(kgrandon) → review+
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8466117 [details] [diff] [review]
theme-color.brightness.patch
Review of attachment 8466117 [details] [diff] [review]:
-----------------------------------------------------------------
R+, but only if you fix the typo in the className first. Clearing to make sure it's done, but feel free to R+ it after that fix :)
::: apps/system/style/chrome/chrome.css
@@ +235,4 @@
> background-image: url("images/dark/back.png");
> }
>
> +.ligth .controls .forward-button {
Should this be `.light`? Please fix this first.
Attachment #8466117 -
Flags: review?(kgrandon)
|
|
Assignee | |
Comment 5•10 years ago
|
||
I fixed the typo and the background-color too dark (I forgot this one as well...).
https://github.com/mozilla-b2g/gaia/commit/1f20f326f317feda0ec59aff011b54a7c62cb9bf
Assignee: nobody → 21
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•