Closed Bug 1047325 Opened 10 years ago Closed 10 years ago

Use the 'search' string for apps and the url for browser frame

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: vingtetun, Unassigned)

References

Details

Attachments

(1 file)

Attached patch search.string.patch (deleted) — Splinter Review
Mostly code removals!
Attachment #8466133 - Flags: review?(kgrandon)
What does this depend on? Getting code conflicts here.
(In reply to Kevin Grandon :kgrandon from comment #2) > What does this depend on? Getting code conflicts here. This one applies on top of master!
For some reason I thought that we wanted to continue to show the app name within rocketbar, I like it better that way, but I guess my understanding could be wrong. Francis - can you confirm that we want to show just 'Search' in the rocketbar within apps?
Flags: needinfo?(fdjabri)
Comment on attachment 8466133 [details] [diff] [review] search.string.patch Review of attachment 8466133 [details] [diff] [review]: ----------------------------------------------------------------- Clearing review until we check with UX. Also I think this might cause a few problems, I noticed launching the Facebook hosted app showed 'Search'. It feels really weird to me - I'd recommend UX to apply this patch and play with it.
Attachment #8466133 - Flags: review?(kgrandon)
I can confirm that for apps that don't request navigation chrome, the rocket bar should show the text "Search". I agree that this is inconsistent behavior, but it avoids the issue of repeating the app title in apps that don't require chrome. If the Rocket bar does always show the app/URL title consistently, then we should make changes to all apps that display their app title to avoid duplication. I'll raise this as a discussion point at a UX frameworks meeting tomorrow.
I discussed this issue and we can put a stop on this bug - the rocket bar will continue to show the app name, but we'll raise bugs on Settings and Messages so that we avoid duplication in the Title. We will be testing this out further in the Usability tests planned for the week of the 18th. Thanks, Francis
Flags: needinfo?(fdjabri)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: