This remove the 'black' flash.

I fixed a positioning issue with the screenshot-overlay in this version.

Nice work, can confirm this works - this also sets the colour of the flashing in bug 1040087, but only at the top - you can still observe the flashing at the bottom. Given that this area appears where the toolbar is meant to be, I'd assert that this colour should be the background colour of the system tray and not white - but white is better than black (unless the page and the chrome had a black background - then this would look as weird as it does pre-patch... But is an unlikely combination right now). Would it be much work to change this to the system tray colour? I think that would provide better results and stop us from having to tackle this again in the future.

Comment on attachment 8466659 [details] [diff] [review] background-color-screenshot-overlay.patch Review of attachment 8466659 [details] [diff] [review]: ----------------------------------------------------------------- +1 to what Chris said. Shouldn't we leverage the same 'light/dark' classes that we do in app_chrome.js? Looks good though!

(In reply to Chris Lord [:cwiiis] from comment #3) > Would it be much work to change this to the system tray colour? I think that > would provide better results and stop us from having to tackle this again in > the future. I guess I'm getting confused by terminology here. What do you refer to as the "system tray"? Is that not rocketbar/the app title?

So in this patch: - default color is white for non scrollable - default color is unset for homescreen window - for browser scrollable window, default color is the default color of the chrome - for window with a theme color set, the color is the color of the theme.

Comment on attachment 8466762 [details] [diff] [review] background-color-screenshot-overlay.patch Review of attachment 8466762 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, I guess it seems fine if web content can not influence theme-color yet.

(In reply to Kevin Grandon :kgrandon from comment #7) > Comment on attachment 8466762 [details] [diff] [review] > background-color-screenshot-overlay.patch > > Review of attachment 8466762 [details] [diff] [review]: > ----------------------------------------------------------------- > > Yeah, I guess it seems fine if web content can not influence theme-color yet. It works for theme-color if web content changed it!