Closed Bug 1047998 Opened 10 years ago Closed 10 years ago

[dialer] Long number is not showed properly (first digits is out of screen)

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Dialer
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: raniere, Assigned: dwi2)

References

Details

Attachments

(2 files)

screenshot demonstrating the bug
(deleted), image/png
Details
Pull request
(deleted), text/x-github-pull-request
rik
: review+
rik
: feedback+
Details
Attached image screenshot demonstrating the bug (deleted) —
Steps to reproduce: 1. Launch the dialer 2. Type an long number (at least 12 digits) Actual Results: The first digits aren't showed or are truncated (see attachment). Expected Results: Change the font size of the numbers (this was the previous behavior) or break the number into two lines. Additional information: - Gaia: commit 445cd4844a35213da74057f4629ee269a29229a0 Date: Sat Aug 2 14:20:40 2014 +0200
Hi, Mind if I take this bug?
Assignee: nobody → tzhuang
Attached file Pull request (deleted) —
Hi Rik, Would you mind reviewing my patch? :) Thanks
Attachment #8469788 - Flags: review?(anthony)
This is a regression of bug 967440.
Status: UNCONFIRMED → ASSIGNED
Depends on: 967440
Ever confirmed: true
Comment on attachment 8469788 [details] Pull request That was a stupid error on my part, thanks for finding this. I'm marking it as feedback+ only because we need new tests. Since you wrote some new tests in bug 1047275, do you mind writing one for this patch? I'll write it if you can. Thanks!
Attachment #8469788 - Flags: review?(anthony) → feedback+
correction: I'll write it if you can't.
Sure, I'll write new tests for it.
Comment on attachment 8469788 [details] Pull request New tests added.
Attachment #8469788 - Flags: review?(anthony)
Comment on attachment 8469788 [details] Pull request Excellent! Thanks a lot.
Attachment #8469788 - Flags: review?(anthony) → review+
landed on gaia master https://github.com/mozilla-b2g/gaia/commit/532fcb917fb67106abbe1046a5fffed416408404
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: