Comment on attachment 8467029 [details] [diff] [review] Fix more bad implicit constructors in XPCOM Review of attachment 8467029 [details] [diff] [review]: ----------------------------------------------------------------- ::: intl/unicharutil/nsSaveAsCharset.cpp @@ +355,5 @@ > mCharsetList.Clear(); > mCharsetListIndex = -1; > } > > + nsCWhitespaceTokenizer tokenizer((nsDependentCString(charsetList))); Is this a typo or some C++ variable-definitions-can-look-like-function-prototypes madness at work?

(In reply to Nathan Froyd (:froydnj) from comment #2) > Comment on attachment 8467029 [details] [diff] [review] > Fix more bad implicit constructors in XPCOM > > Review of attachment 8467029 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: intl/unicharutil/nsSaveAsCharset.cpp > @@ +355,5 @@ > > mCharsetList.Clear(); > > mCharsetListIndex = -1; > > } > > > > + nsCWhitespaceTokenizer tokenizer((nsDependentCString(charsetList))); > > Is this a typo or some C++ > variable-definitions-can-look-like-function-prototypes madness at work? The latter.