Closed Bug 1048359 Opened 10 years ago Closed 10 years ago

Update to use gaia-header v0.2.6

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(ux-b2g:2.1)

Status:
RESOLVED FIXED
Project Flags:
ux-b2g 2.1

People

(Reporter: wilsonpage, Assigned: wilsonpage)

Details

Attachments

(1 file, 1 obsolete file)

pull-request (master)
(deleted), text/x-github-pull-request
caseyyee.ca
: review+
Details
No description provided.
Summary: Update to use gaia-header@0.2.5 → Update to use gaia-header v0.2.5
Attached file pull-request (master) (obsolete) (deleted) —
Attachment #8467143 - Flags: review?(yor)
v0.2.5 comes with: - Improved l10n shadow-dom solution (see gaia-header readme) - Bug fix with font-fit.js being run at wrong time
Assignee: nobody → wilsonpage
Attached file pull-request (master) (deleted) —
Attachment #8467143 - Attachment is obsolete: true
Attachment #8467143 - Flags: review?(yor)
Attachment #8467151 - Flags: review?(yor)
Summary: Update to use gaia-header v0.2.5 → Update to use gaia-header v0.2.6
Attachment #8467151 - Flags: review?(kyee)
Comment on attachment 8467151 [details] pull-request (master) Looks good. The only suggestion I can make is that the class name for .supported-action should be a bit more descriptive. Maybe something like .is-visible or .is-hidden Otherwise looks fine r+
Attachment #8467151 - Flags: review?(kyee) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
ux-b2g: --- → 2.1
Attachment #8467151 - Flags: review?(yor)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: